After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 514064 - Use gio calls instead of launching gnome-open
Use gio calls instead of launching gnome-open
Status: RESOLVED FIXED
Product: vinagre
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: vinagre-maint
vinagre-maint
Depends on:
Blocks:
 
 
Reported: 2008-02-03 13:12 UTC by Jaap A. Haitsma
Modified: 2008-08-18 17:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
The patch (2.06 KB, patch)
2008-02-03 13:13 UTC, Jaap A. Haitsma 		rejected Details | Review

Description Jaap A. Haitsma 2008-02-03 13:12:50 UTC 
This patch removes a run time dependency on gnome-open and also considerably simplifies the code

Permission to apply?
Comment 1 Jaap A. Haitsma 2008-02-03 13:13:40 UTC 
Created attachment 104314 [details] [review]
The patch
Comment 2 Jonh Wendell 2008-02-06 15:43:48 UTC 
Hi, Jaap. I can't try your patch because I don't have glib 2.15.5 (I'm not using trunk, I'm using Ubuntu Hardy).

I'm happy with it, if it works fine.

As long I can test it I let you know, in order to commit.

Thanks.
Comment 3 Jaap A. Haitsma 2008-02-07 07:23:06 UTC 
Jonh, I discovered that in order to this correctly if you have multiple screens you need to use a GdkAppLaunchContext. Which is in GTK 2.15. So I think it's better to wait for GNOME 2.24
Comment 4 Emilio Pozuelo Monfort 2008-03-27 11:21:58 UTC 
I guess you meant GTK 2.13, as 2.15 hasn't been released yet :)
Comment 5 Jaap A. Haitsma 2008-03-27 21:59:22 UTC 
The plan of the GTK guys a while ago was to skip 2.14 hence 2.15. Later on they came back on that
Comment 6 Jonh Wendell 2008-06-30 18:50:00 UTC 
Hi, Jaap. How is this now?
Comment 7 Jaap A. Haitsma 2008-06-30 18:52:46 UTC 
Hi Jonh,

If you want to depend on GTK 2.13.1 you can use the new function gtk_show_uri
See
http://live.gnome.org/GnomeGoals/RemoveGnomeOpenGnomeHelp
Comment 8 Jonh Wendell 2008-08-18 17:16:34 UTC 
OK, fixed with new gtk+ API.

Thanks.