After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 512208 - QIF Import: New commodities remain if import canceled
QIF Import: New commodities remain if import canceled
Status: VERIFIED FIXED
Product: GnuCash
Classification: Other
Component: Import - QIF
2.2.x
Other All
: Normal minor
: ---
Assigned To: Charles Day
Derek Atkins
Depends on:
Blocks: backport
 
 
Reported: 2008-01-26 11:26 UTC by Charles Day
Modified: 2018-06-29 22:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
QIF file demonstrating the bug (173 bytes, text/plain)
2008-01-26 11:27 UTC, Charles Day
Details

Description Charles Day 2008-01-26 11:26:31 UTC
Please describe the problem:
During import, new GnuCash commodities may be created. If the import is canceled, these commodities should be removed, but they aren't.

Steps to reproduce:
1. Start GnuCash with the --nofile option.
2. Begin importing a QIF file containing a transaction involving a QIF security (such as the example attached).
3. At the final step of the druid, click Cancel.
4. Open the Security Editor (Tools -> Security Editor)

Actual results:
There is a commodity listed in the Security Editor.

Expected results:
There should not be any commodities listed in the Security Editor.

Does this happen every time?
Yes.

Other information:
Comment 1 Charles Day 2008-01-26 11:27:26 UTC
Created attachment 103773 [details]
QIF file demonstrating the bug
Comment 2 Derek Atkins 2008-01-26 13:44:35 UTC
This isn't limited to the QIF importer.  It happens in all of them.
Indeed, in the OFX/HBCI importer new accounts will also be left even if you cancel the import.

I just dont see this as a huge bug, honestly.
Comment 3 Charles Day 2008-01-26 20:36:17 UTC
No, I don't think it's a huge bug either, so I only used a "minor" severity. I guess the OFX/HBCI importer is in worse shape, at least as far as canceling goes. It shouldn't be hard to fix, I think, though I'll have to dip my toe into the C code. (But I'm far more comfortable with C than Scheme anyway.)
Comment 4 Charles Day 2008-04-16 21:29:56 UTC
Fix committed as r17088. Requesting backport for 2.2.
Comment 5 Andreas Köhler 2008-04-26 14:53:20 UTC
Applied to branches/2.2 as r17112 for GnuCash 2.2.5.
Thanks a lot!
Comment 6 John Ralls 2018-06-29 22:00:14 UTC
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=512208. Please update any external references or bookmarks.