GNOME Bugzilla – Bug 511700
port to gio
Last modified: 2008-02-11 22:02:38 UTC
port gnome-terminal from gnome-vfs to gio
Created attachment 103603 [details] [review] patch i'm confused that configure.in listed GLIB twice: GLIB_REQUIRED=2.15.2 GLIB_REQUIRED=2.12.0 i have removed the latter one. the #include <libgnomevfs/gnome-vfs-utils.h> in /src/terminal-screen.c was obsolete and just forgotten there. please review this carefully, i'm a total idiot with regard to code patches, but was in the mood to try something new. thanks :)
+ if (file_info != NULL) { + mime_type = g_file_info_get_content_type (file_info); + g_object_unref (file_info); mime_type now points to freed memory. + file_info = g_file_query_info (file1, We only support local files here for now, so querying sync should be ok. Should file a bug to move to _real_ gio though, i.e. supporting remote files here :)
Created attachment 104000 [details] [review] patch let's see if i have more luck this time. if not, feel free to fix anything and commit if you have time...
Looks ok to me now :)
Committed.