After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 511507 - enable_notify not properly defined / supported
enable_notify not properly defined / supported
Status: RESOLVED FIXED
Product: gnome-mount
Classification: Deprecated
Component: programs
unspecified
Other Linux
: Normal normal
: ---
Assigned To: David Zeuthen (not reading bugmail)
Depends on:
Blocks:
 
 
Reported: 2008-01-23 10:56 UTC by Loïc Minier
Modified: 2008-06-27 09:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
AC_MSG_ERROR if libnotify >= 0.3.0 is missing; drop useless AC_SUBST (701 bytes, patch)
2008-01-23 10:58 UTC, Loïc Minier 		reviewed Details | Review

Description Loïc Minier 2008-01-23 10:56:02 UTC 
Hi,

When building on a system without libnotify:
gnome-mount.c:39:30: erreur: libnotify/notify.h : Aucun fichier ou répertoire de ce type


Configure.ac checks are like:
PKG_CHECK_MODULES([NOTIFY], [libnotify >= 0.3.0], [enable_notify=yes], [enable_notify=yes])
if test "x$enable_notify" != "xno"; then
   AC_DEFINE_UNQUOTED([ENABLE_NOTIFY], 1, [Enable notifications with libnotify])
   AC_SUBST(NOTIFY_CFLAGS)
   AC_SUBST(NOTIFY_LIBS)
fi

So it's always enable_notify=yes...

Looking at gnome-mount.c, there's not enough NOTIFY ifdef use anyway, so I think libnotify should simply be made mandatory to build gnome-mount.

Will attach a patch to require it in configure; I'm leaving the enable_notify bits in place if someone wants to complete them.

Bye,
Comment 1 Loïc Minier 2008-01-23 10:58:37 UTC 
Created attachment 103538 [details] [review]
AC_MSG_ERROR if libnotify >= 0.3.0 is missing; drop useless AC_SUBST
Comment 2 Cosimo Cecchi 2008-06-27 09:49:17 UTC 
I fixed this in trunk adding the missing #ifdefs and #includes.

2008-06-27  Cosimo Cecchi  <cosimoc@gnome.org>

	* configure.in:
	* src/gnome-mount.c: (unmount_cache_timeout_start),
	(unmount_cache_timeout_cancel):
	Make the dependency on libnotify really optional. (#511507).