After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 510841 - git-cvsimport and git-svn broken in trunk + git stash arguments has changed
git-cvsimport and git-svn broken in trunk + git stash arguments has changed
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2008-01-20 16:55 UTC by Marc-Andre Lureau
Modified: 2008-03-09 18:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[1/1] 2008-01-19 Marc-Andre Lureau <marcandre.lureau@gmail.com> (8.25 KB, patch)
2008-01-20 17:05 UTC, Marc-Andre Lureau
none Details | Review

Description Marc-Andre Lureau 2008-01-20 16:55:42 UTC
I have a quick patch to that.
Comment 1 Marc-Andre Lureau 2008-01-20 17:05:30 UTC
Created attachment 103263 [details] [review]
[1/1] 2008-01-19  Marc-Andre Lureau <marcandre.lureau@gmail.com>


        * jhbuild/versioncontrol/git.py: Fix git-svn and git-cvsimport.
---
 ChangeLog                     |   60 ++++++++++++++++++++++-------------------
 jhbuild/versioncontrol/git.py |    6 ++--
 2 files changed, 35 insertions(+), 31 deletions(-)
Comment 2 Marc-Andre Lureau 2008-01-20 17:06:10 UTC
Sorry for the Changelog, my editor remove trailing whitespaces :), 
Comment 3 Frederic Peters 2008-01-20 17:12:53 UTC
Will it work with all git >1.5 ?
Comment 4 Marc-Andre Lureau 2008-01-20 17:23:32 UTC
(In reply to comment #3)
> Will it work with all git >1.5 ?
> 

I don't know. I was surprised that "stash save' was not the default action anymore.

Anyway, this seems also a safe change (as we do not rely on a default behavior when no command is given)
Comment 5 Frederic Peters 2008-01-20 17:27:24 UTC
Okay; please commit it (but pay attention to your ChangeLog, it had lots of cruft).
Comment 6 Marc-Andre Lureau 2008-01-20 17:35:21 UTC
Okay

There are other stuffs that needs to be changed.
I'll post a new patch later.
Comment 7 Marc-Andre Lureau 2008-03-09 18:09:41 UTC
this is now fixed and committted. I forgot that bug existed.

commit r1919