After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 510667 - Metacity compositor doesn't work fine with g[dt]k_window_set_opacity()
Metacity compositor doesn't work fine with g[dt]k_window_set_opacity()
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: Iain's compositor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Metacity compositor maintainers
Metacity compositor maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-19 19:45 UTC by Carlos Garnacho
Modified: 2008-04-22 14:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.35 KB, patch)
2008-01-19 19:47 UTC, Carlos Garnacho
none Details | Review
updated patch, use correct types in ignored XQueryTree args (1.35 KB, patch)
2008-01-19 21:10 UTC, Carlos Garnacho
committed Details | Review
testcase (337 bytes, text/x-csrc)
2008-04-22 13:09 UTC, Carlos Garnacho
  Details

Description Carlos Garnacho 2008-01-19 19:45:30 UTC
As far as I've learnt, applications can set the _NET_WM_WINDOW_OPACITY property to their toplevels (gtk/gdk functions do this) and it's the compositor responsability to propagate these settings to the frame window, but this doesn't happen in metacity compositor, which just tries to do that to the window that received the event.

I'm going to attach a patch to fix this.
Comment 1 Carlos Garnacho 2008-01-19 19:47:24 UTC
Created attachment 103217 [details] [review]
patch
Comment 2 Carlos Garnacho 2008-01-19 21:10:12 UTC
Created attachment 103222 [details] [review]
updated patch, use correct types in ignored XQueryTree args
Comment 3 Thomas Thurman 2008-02-17 22:55:12 UTC
This seems reasonable to me; Iain, do you have any comment?
Comment 4 Carlos Garnacho 2008-04-22 13:09:01 UTC
Created attachment 109686 [details]
testcase

Will the testcase help commit this bugfix?
Comment 5 iain 2008-04-22 13:23:46 UTC
oh, this looks ok to commit... guess i never saw this bug.
Comment 6 Thomas Thurman 2008-04-22 13:35:11 UTC
In it goes. Thanks.

http://svn.gnome.org/viewvc/metacity?rev=3692&view=rev
Comment 7 Carlos Garnacho 2008-04-22 14:27:41 UTC
Thanks! :)