After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 509406 - split/rename general metadata support from libexif support.
split/rename general metadata support from libexif support.
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-01-14 16:15 UTC by Claudio Saavedra
Modified: 2013-10-30 18:41 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Claudio Saavedra 2008-01-14 16:15:35 UTC
Motivated from bug #509149. Currently, some classes and properties related to the metadata support are named "EogExif*" and the like, even when they are useful with exempi and could also be used for general metadata support.

I think it would be a good idea to rename these classes and objects everywhere, and make sure there's no confusion on what's really EXIF related and what can be used for other metadata sources as well.
Comment 1 Lucas Rocha 2008-03-23 23:14:43 UTC
Hey Claudio, could you elaborate, please? What exactly are you proposing?
Comment 2 Claudio Saavedra 2008-03-25 02:05:52 UTC
Things like this:

  #if HAVE_METADATA
	  GtkWidget      *exif_box;
  #endif

are confusing and had lead to some compile failures when libexif or exempi is not available (see bug #509149). That widget in particular should be called metadata_box or something similar. 

There are other widgets (and probably classes, I don't remember exactly now) that should no longer be named exif_something/EogExif*/etc, because they are no longer used exclusively for EXIF metadata.

It's mostly a matter of cleaning up.
Comment 3 Lucas Rocha 2008-03-25 11:17:24 UTC
Ok, it makes sense. Feel free to do it. :-)
Comment 4 Felix Riemann 2013-10-30 18:41:04 UTC
Hmm, doesn't seem to be much left...

commit 04d53c3c8d475c259c477f627038849ae79dd6ed
Author: Felix Riemann <>
Date:   Wed Oct 30 19:27:49 2013 +0100

    EogPropertiesDialog: Separate Exif/XMP-specific widgets from generic ones
    
    This is just renaming a few widgets.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=509406

commit 2969a58b0ceeb8c6af1e04c39aa230e72b70ea20
Author: Felix Riemann <>
Date:   Wed Oct 30 19:05:12 2013 +0100

    EogExifDetails: Rename to EogMetadataDetails
    
    The widget is not specific to Exif, and is used for XMP as well.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=509406
---
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.