GNOME Bugzilla – Bug 508910
Add bug-buddy support to cheese.desktop
Last modified: 2008-01-26 11:51:48 UTC
Adding some X-GNOME-Bugzilla-* keys to cheese.desktop, bug-buddy will be able to automatically send crash reports to bugzilla.gnome.org. Here is the patch, also fixing .desktop file syntax (thanks to `desktop-file-validate` utility). OK to commit?
Created attachment 102655 [details] [review] The proposed patch
this seems ok to me, but will break the desktop file installation for waf. do you mind checking that too?
I don't know waf, I'll try to check it. But all you need is "convert" .desktop.in.in file to .desktop.in before running intltool, replacing the @VERSION@ with the cheese current version
can you show me the ruleset autotool uses?
Daniel, waf does not support this. It should be one of the items on our waf for GNOME todo list. My suggestion is to let Luca apply the patch. We can see in the autofoo build what commands are necessary to process a desktop.in.in file and make a patch for waf Luca, I always thought that for bug buddy support gnome_program_init was necessary. We use gtk_init
i think it shouldnt be too hard to add it to waf, as this "conversion" is just replacing @VERSION@ imho...
(In reply to comment #4) > can you show me the ruleset autotool uses? > Honestly... dunno. I just know that you (i.e. GNOME developer) can simply put the @VERSION@ placeholder in .desktop.in.in then add .desktop.in in AC_OUTPUT list in configure.[ac|in]. Running configure, the generated .desktop.in will have the proper version value, grabbed from configure. BTW it seems that X-GNOME-Bugzilla-Version is optional. See http://live.gnome.org/TwoPointFifteen/ReleaseNotes -> For Developers
(In reply to comment #5) > Daniel, > > Luca, > > I always thought that for bug buddy support gnome_program_init was necessary. > We use gtk_init > From 2.19.0 NEWS: build a GTK_MODULE invoking bug-buddy on segfaults.
For more info about supported X-GNOME-Bugzilla keys, check this email from Olav Vitters to desktop-devel-list http://mail.gnome.org/archives/desktop-devel-list/2006-August/msg00162.html
luca, please commit it
2008-01-13 Luca Ferretti <elle.uca@libero.it> reviewed by: Daniel G. Siegel and Jaap A. Haitsma * configure.ac: * data/cheese.desktop.in: * data/cheese.desktop.in.in: Add X-GNOME-Bugzilla-* keys and validate .desktop file. Fix bug #508910 when waf will be able to generate .in from .in.in Committed (revision 391)
your name alone would be enough ;)
2008-01-18 Jaap Haitsma <jaap@haitsma.org> * data/wscript_build, wscript: Process desktop.in.in with waf