GNOME Bugzilla – Bug 508675
Applying change in Orca preference dialog is a little bit slow.
Last modified: 2009-01-20 20:54:37 UTC
Please describe the problem: It is a little bit longer to apply any changes in preferences than user expected. Steps to reproduce: 1. launch Orca and go to "Braille" tab 2. Check 'Enable Braille monitor' 3. Press Apply 4. Press OK Actual results: after #3 and #4, it always takes several seconds (5 seconds in my computer)to make the change in orca preferences. Expected results: Change immediately after click "Apply" and "OK" buttons. It is a little bit longer to apply any changes in preferences than user expected. Does this happen every time? yes Other information: It is not a serious bug but the performance of Orca preference dialog need to improve.
Thank you Emily!
Created attachment 122957 [details] [review] patch to illustrate current timings with the above patch (to show timings), we get the current info: applying took 7.46126413345 _cleanupSpeechServers took 0.0173380374908 destroying window took 7.06146082878 aprox 14 seconds overall, for pressing ok in the preferences.
Created attachment 122958 [details] [review] modified code with timing modification: applying took 2.25891494751 _cleanupSpeechServers took 0.0121560096741 destroying window took 7.0944231987 shaves a few seconds :)
Created attachment 122960 [details] [review] patch without timing info clean patch to be applied to trunk. 2.24 branch?
Woo hoo! Thanks Jon. Nice work. Committed this to trunk and gnome-2-24. I'm not sure we're ready to close this just yet because it still takes a noticeable amount of time to close the window. But...your analysis was great and the speed boost is awesome, too. Thanks so much.
Created attachment 122997 [details] [review] another patch that saves time redusing the time taken to destroy the window., it was in the 7 range, now down to 1.9 ish. :)
Thanks! Committed to trunk and gnome-2-24. This is not only faster, but it also seems to help reduce the amount of time that a blank Orca preferences dialog appears on the screen. Nice job.