After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 507258 - [patch] Avoid warnings with telepathy-glib >= 0.7.1
[patch] Avoid warnings with telepathy-glib >= 0.7.1
Status: RESOLVED FIXED
Product: gnome-phone-manager
Classification: Other
Component: telepathy
0.40
Other All
: Normal minor
: ---
Assigned To: none
none
Depends on:
Blocks:
 
 
Reported: 2008-01-04 13:15 UTC by Simon McVittie
Modified: 2008-01-07 11:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (445 bytes, patch)
2008-01-04 13:16 UTC, Simon McVittie 		committed Details | Review

Description Simon McVittie 2008-01-04 13:15:27 UTC 
telepathy-glib 0.7.1 will change TpChannelIface to make the "channel-type" property construct-only and writeable, instead of read-only, for the benefit of the new client-side code (the change is already present in the darcs version).

When a channel is constructed, the GObject infrastructure will call the set_property callback to set channel-type to the default value (NULL), causing a warning.

To avoid warnings when a channel is constructed, please ignore attempts to set the channel type, the same way you now ignore attempts to set the handle type. The attached patch should be sufficient.

See also https://bugs.freedesktop.org/show_bug.cgi?id=13896 (originally filed against Gabble).
Comment 1 Simon McVittie 2008-01-04 13:16:33 UTC 
Created attachment 102111 [details] [review]
Proposed patch
Comment 2 Bastien Nocera 2008-01-07 09:57:56 UTC 
Looks good to me, you know the code better than I do ;)
Comment 3 Simon McVittie 2008-01-07 11:30:42 UTC 
Well, I'm not a committer (as far as I know anyway :-) so please commit my patch if you like it.

(I assume patches in Bugzilla are the right way for Telepathy hackers to get changes like this into g-p-m? If there's a better way, let me know - as far as I know, most of us don't have Gnome commit access)
Comment 4 Bastien Nocera 2008-01-07 11:42:48 UTC 
Bugzilla is good, and you can/should ask for an account as well. Thanks for the patch!

2008-01-07  Bastien Nocera  <hadess@hadess.net>

        * telepathy/im-channel.c: (phoney_im_channel_set_property):
        Patch from Simon McVittie <simon.mcvittie@collabora.co.uk>
        to avoid warnings with telepathy >= 0.7.1 (Closes: #507258)