After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503922 - "Status is Draft" criterion does not work
"Status is Draft" criterion does not work
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
2.22.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2007-12-16 21:47 UTC by Matt McCutchen
Modified: 2008-07-07 09:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Patch (527 bytes, patch)
2008-07-01 22:51 UTC, Matt McCutchen
committed Details | Review

Description Matt McCutchen 2007-12-16 21:47:53 UTC
Please describe the problem:
A "Status is Draft" criterion on a search folder fails to match messages that are drafts.

Steps to reproduce:
1. Compose a message and save it as a draft.
2. Create a search folder with the single criterion "Status", "is", "Draft".
3. Open the search folder.


Actual results:
The draft does not appear in the search folder.

Expected results:
The draft appears in the search folder.

Does this happen every time?
Yes.

Other information:
This is the result of a simple blooper in the mapping of flag names to values in evolution-data-server/camel/camel-folder-summary.c :

static struct flag_names_t {
	char *name;
	guint32 value;
} flag_names[] = {
	{ "answered", CAMEL_MESSAGE_ANSWERED },
	{ "deleted", CAMEL_MESSAGE_DELETED },
	{ "draft", CAMEL_MESSAGE_DELETED }, /* should be CAMEL_MESSAGE_DRAFT */
	{ "flagged", CAMEL_MESSAGE_FLAGGED },
	{ "seen", CAMEL_MESSAGE_SEEN },
	{ "attachments", CAMEL_MESSAGE_ATTACHMENTS },
	{ "junk", CAMEL_MESSAGE_JUNK },
	{ "secure", CAMEL_MESSAGE_SECURE },
	{ NULL, 0 }
};

I made a modified version of Evolution with the mapping fixed and the "Status is Draft" criterion worked correctly.
Comment 1 Matthew Barnes 2008-03-11 01:01:47 UTC
Bumping version to a stable release.
Comment 2 Matt McCutchen 2008-07-01 21:59:12 UTC
Fedora users who are annoyed by this bug may wish to use my modified evolution-data-server RPMs:

http://mattmccutchen.net/email/#rpm
Comment 3 Matthew Barnes 2008-07-01 22:33:03 UTC
I don't see a patch here.  But you've gone and provided your own RPMs?
Comment 4 Matt McCutchen 2008-07-01 22:51:42 UTC
Created attachment 113819 [details] [review]
Patch
Comment 5 Srinivasa Ragavan 2008-07-02 10:49:47 UTC
looks right to me. 
Comment 6 Jeffrey Stedfast 2008-07-02 16:01:00 UTC
yes, please commit :)
Comment 7 Suman Manjunath 2008-07-07 09:04:13 UTC
Patch committed to SVN trunk as r9097
http://svn.gnome.org/viewvc/evolution-data-server?view=revision&revision=9097