GNOME Bugzilla – Bug 503903
File chooser dialog opened for uploading files doesn't show image preview
Last modified: 2007-12-17 14:35:28 UTC
It's a bit anyoing have to remember the title of an image for uploading it. For example, file selector opened from gnome-appearance-properties (in wallpapers tab) for adding a wallpaper already has this feature Thanks a lot for using this file-selector in epiphany for uploading files Other information: I attach two screenshots with both behaviors
Created attachment 101070 [details] current.png Current file-selector opened, for example, now, for uploading this image
Created attachment 101071 [details] wanted.png Expected file-selector :-) Thanks a lot
Thanks for your bug report. Epiphany already has this feature, though to enable it you have to compile it with the "--enable-filepicker" configure flag (BTW, why is it not default?) *** This bug has been marked as a duplicate of 440859 ***
Because it's not in .20, it's in trunk only :). I don't recall if trunk has it by default, but I think it does.
I think it should be default, but actually isn't. configure.ac has this AC_ARG_ENABLE([filepicker], AS_HELP_STRING([--enable-filepicker],[Whether to enable the gtk+ native filepicker; not needed when the mozilla build itself has native gtk+ filepicker enabled (default:enabled)]), [],[enable_filepicker=no]) which is self-contradictory, as it tells the filepicker is enabled by default but sets the default value to no. What should we change? The string or the default value?
Yep yep, I just commited a s/no/yes!.
Then, Is this filepicker only available for epiphany from trunk? (I only have 2.20.*)
Yes, this is only in trunk or in 2.21.4 (released two days ago).
With --enable-filepicker build of 2.20.2 fails with: FilePicker.cpp: In destructor 'virtual GFilePicker::~GFilePicker()': FilePicker.cpp:67: warning: dereferencing type-punned pointer will break strict-aliasing rules FilePicker.cpp: At global scope: FilePicker.cpp:76: error: prototype for 'nsresult GFilePicker::Init(nsIDOMWindowInternal*, const PRUnichar*, PRInt16)' does not match any in class 'GFilePicker' FilePicker.h:50: error: candidate is: virtual nsresult GFilePicker::Init(nsIDOMWindow*, const nsAString&, PRInt16) FilePicker.cpp: In member function 'nsresult GFilePicker::Init(nsIDOMWindowInternal*, const PRUnichar*, PRInt16)': FilePicker.cpp:134: warning: dereferencing type-punned pointer will break strict-aliasing rules FilePicker.cpp: At global scope: FilePicker.cpp:193: error: prototype for 'nsresult GFilePicker::AppendFilter(const PRUnichar*, const PRUnichar*)' does not match any in class 'GFilePicker' FilePicker.h:50: error: candidate is: virtual nsresult GFilePicker::AppendFilter(const nsAString&, const nsAString&) FilePicker.cpp:245: error: prototype for 'nsresult GFilePicker::GetDefaultString(PRUnichar**)' does not match any in class 'GFilePicker' FilePicker.h:50: error: candidate is: virtual nsresult GFilePicker::GetDefaultString(nsAString&) FilePicker.cpp:264: error: prototype for 'nsresult GFilePicker::SetDefaultString(const PRUnichar*)' does not match any in class 'GFilePicker' FilePicker.h:50: error: candidate is: virtual nsresult GFilePicker::SetDefaultString(const nsAString&) FilePicker.cpp:293: error: prototype for 'nsresult GFilePicker::GetDefaultExtension(PRUnichar**)' does not match any in class 'GFilePicker' FilePicker.h:50: error: candidate is: virtual nsresult GFilePicker::GetDefaultExtension(nsAString&) FilePicker.cpp:304: error: prototype for 'nsresult GFilePicker::SetDefaultExtension(const PRUnichar*)' does not match any in class 'GFilePicker' FilePicker.h:50: error: candidate is: virtual nsresult GFilePicker::SetDefaultExtension(const nsAString&) FilePicker.cpp: In member function 'virtual nsresult GFilePicker::GetDisplayDirectory(nsILocalFile**)': FilePicker.cpp:338: error: 'NS_LOCAL_FILE_CONTRACTID' was not declared in this scope FilePicker.cpp:338: error: 'do_CreateInstance' was not declared in this scope FilePicker.cpp: In member function 'virtual nsresult GFilePicker::GetFile(nsILocalFile**)': FilePicker.cpp:390: error: 'NS_LOCAL_FILE_CONTRACTID' was not declared in this scope FilePicker.cpp:390: error: 'do_CreateInstance' was not declared in this scope FilePicker.cpp: In member function 'virtual nsresult GFilePicker::GetFileURL(nsIFileURL**)': FilePicker.cpp:411: error: 'do_CreateInstance' was not declared in this scope FilePicker.cpp: In member function 'virtual nsresult GFilePicker::Show(PRInt16*)': FilePicker.cpp:437: error: no matching function for call to 'AutoWindowModalState::AutoWindowModalState()' AutoWindowModalState.h:30: note: candidates are: AutoWindowModalState::AutoWindowModalState(nsIDOMWindow*) AutoWindowModalState.h:28: note: AutoWindowModalState::AutoWindowModalState(const AutoWindowModalState&) make[4]: *** [libephymozillaembed_la-FilePicker.lo] Error 1
This is not supported on 2.20.x. Use svn trunk.
OK, thanks