After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 503413 - enhance remote control interface: toggle mute
enhance remote control interface: toggle mute
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
1.1.x
Other All
: Normal enhancement
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks: 554318
 
 
Reported: 2007-12-13 13:31 UTC by Mike
Modified: 2008-12-05 15:13 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
Adds toggle mute to the remote control interface. (3.59 KB, patch)
2008-06-29 11:36 UTC, Iestyn Pryce
none Details | Review

Description Mike 2007-12-13 13:31:42 UTC
There are commands totem --volume-up/down nut no the similar command to toggle mute.
To make remote control interface a "complete" solution for remote controlling it would be useful to have the similar command for toggle mute functionality.
Comment 1 Bastien Nocera 2007-12-13 14:23:10 UTC
We don't handle "mute", we only handle 0-volume. I'd be happy to add get/set-volume command-line options though.
Comment 2 Mike 2007-12-13 14:49:58 UTC
From "remote conroller" side of view it is more easy to operate
by toggle_mute requests (inside totem it could be realized as 0-volume/previous-volume of cource). 
In this case there are no needs to store volume value somethere for "remote controller"
Comment 3 Iestyn Pryce 2008-06-29 11:36:00 UTC
Created attachment 113604 [details] [review]
Adds toggle mute to the remote control interface.

This patch adds --mute remote control interface to toggle mute.
As this is my first code patch for gnome I'm not terribly sure if this is a good/proper implementation.
Comment 4 Bastien Nocera 2008-08-29 11:37:21 UTC
I'd rather you added a totem_action_toggle_mute() function, and did all the work in there instead.
Comment 5 Bastien Nocera 2008-12-05 15:13:22 UTC
2008-12-05  Bastien Nocera  <hadess@hadess.net>

        * src/totem-options.c (totem_options_process_for_server):
        * src/totem-options.h:
        * src/totem-private.h:
        * src/totem.c (totem_action_exit), (totem_action_volume_relative),
        (totem_action_volume_toggle_mute),
        (volume_button_value_changed_cb), (totem_action_remote):
        * src/totem.h: Add proper support for mute toggling through
        the remote interface, and add a command-line option for it
        (Closes: #554318)