After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 502962 - Render layout to Cairo surface
Render layout to Cairo surface
Status: RESOLVED FIXED
Product: libgnomekbd
Classification: Core
Component: Drawing
2.21.x
Other Linux
: Normal enhancement
: ---
Assigned To: libgnomekbd maintainers
Sergey V. Udaltsov
Depends on:
Blocks: 502961
 
 
Reported: 2007-12-11 01:17 UTC by Ed Catmur
Modified: 2007-12-17 22:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
libgnomekbd-render.patch (29.03 KB, patch)
2007-12-11 01:18 UTC, Ed Catmur 		none Details | Review
xkb_state_notify_event_filter-nocrash.patch (622 bytes, patch)
2007-12-17 02:01 UTC, Ed Catmur 		none Details | Review

Description Ed Catmur 2007-12-11 01:17:52 UTC 
libgnomekbd needs to be able to render a GkbdDrawing to a cairo_t, to enable printing of layouts (bug 502961).
Comment 1 Ed Catmur 2007-12-11 01:18:45 UTC 
Created attachment 100725 [details] [review]
libgnomekbd-render.patch

Proposed patch.
Comment 2 Sergey V. Udaltsov 2007-12-11 22:55:24 UTC 
Great! Committed! Though I found some problems with your patch - it crashes on key press/release (no cairo was available in the context). Had to fix it myself. Please check.
Comment 3 Ed Catmur 2007-12-17 02:01:41 UTC 
Created attachment 101087 [details] [review]
xkb_state_notify_event_filter-nocrash.patch

I knew there was something I'd missed. :)

You missed one crash, in xkb_state_notify_event_filter.  Here's the patch.  Sorry about that.
Comment 4 Sergey V. Udaltsov 2007-12-17 22:05:42 UTC 
Well spotted about indicators! Committed this one too.