GNOME Bugzilla – Bug 502205
Inserting emoticons in HTML messages just inserts a link instead of attaching
Last modified: 2007-12-17 14:52:31 UTC
Forwarding from a downstream bug report: http://bugzilla.redhat.com/show_bug.cgi?id=401451 Description of problem: When composing a message in evolution, the Insert->Emoticon menu option inserts an HTML <IMG> tag in the message which just references the PNG file on the local machine. This is useless for anyone reading the message on a non-Linux (even non-Fedora, or non-Gnome) platform. It ought to attach the smiley to the message and refer to the attachment in the <IMG> tag. Version-Release number of selected component (if applicable): evolution-2.12.1-3.fc8 How reproducible: Insert an emoticon in an HTML message in the evolution message composer. Steps to Reproduce: 1.Ctrl-N or click on "New Mail Message" in evolution main window. 2.Make sure Format->HTML is checked. 3.Choose Insert->Emoticon->Smiley in the body of the message. 4.Send the message. Actual results: The body of the message sent contains an HTML tag <IMG SRC="/usr/share/icons/gnome/16x16/emotes/stock_smiley-1.png"> and the message has no attachments. Anyone reading the message on a machine which doesn't have that file in that particular location won't be able to see the smiley. Expected results: The file /usr/share/icons/gnome/16x16/emotes/stock_smiley-1.png should have been attached to the message, and then the <IMG> HTML tag should have referred to that attachment.
Created attachment 100475 [details] [review] Proposed patch
It works fine, but should be improved a bit, because if I save the html message into Drafts and insert there say 3 emoticons, then when I restore the message to continue editing, I got on console 3 same messages: gtkhtml-WARNING **: No such file or directory
(In reply to comment #2) > It works fine, but should be improved a bit, because if I save the html message > into Drafts and insert there say 3 emoticons, then when I restore the message > to continue editing, I got on console 3 same messages: > gtkhtml-WARNING **: No such file or directory That's a symptom of the problem I'm fixing but I don't see that with the patched version. The emoticons appear fine for me when saved to Drafts.
Strange, I saw this warning even with the patch applied to gtkhtml. My stack trace for the message is this:
+ Trace 181863
I would like to add, I have the patch applied, because the difference between with and without is that the "with" version adds the images as attachments, but the "without" version not. Both shows the message on console.
Hmm, okay I'll take another look at it.
Milan, I can reproduce the warning you're seeing on an unpatched GtkHTML: 1) Enable the "Automatically insert emoticon images" option in Evolution 2) Compose a message with emoticons by typing things like ":-)" or ":-(" (instead of via the Insert -> Emoticon menu). The pictograms should change to smiley images. 3) Save the message to your Drafts folder and close it. 4) Reopen the message from your Drafts folder. 5) Warnings appear on the terminal, but the message renders fine. (evolution:10984): gtkhtml-WARNING **: No such file or directory I think this is a separate bug. Looks like GtkHTML is trying to open the MIME Content-Id as if it were a file on the filesystem. But the message does reopen correctly, so I think the warning is of minor importance for now. Feel free to investigate further if you wish.
OK, we can solve the other thing in other bug, as you suggested. In that case, feel free to commit to trunk, but do not forget to file new bug for that issue.
Committed to trunk (revision 8653). Filed bug #504051 for the warning messages observed here.