GNOME Bugzilla – Bug 502204
[0.11] rtpmanager uses %d to printf unsigned ssrc/pt
Last modified: 2011-11-28 13:28:58 UTC
I'm attaching a patch against CVS rtpmanager to replace the %d with %u on unsigned values (other I get pads named src_-32313213 ... )
Created attachment 100472 [details] [review] patch to replace %d with %u
Created attachment 100483 [details] [review] Fixed patch, the first one was a tiny bit too aggressive
The thing is that we assume that the padname is generated from the padtemplate name, which in turn only allows for %d signs. It's probably not going to cause many problems but I need to check it out in more detail.
Afaik, this is just cosmetic.. If we go for %d, then I'll have farsight do that too, although it looks a bit strange, maybe using %u everywhere may be more logical (but thats probably 0.12 material).
It's not a big deal, we could add %u to the accepted padtemplate strings and then everything is fine and neat. Currently, if you receive a new-pad from a padtemplate, you are supposed to be able to parse the padname with the template name and scanf(), scanning an unsigned int with %d probably works but it's not very nice.
%u is added to the accepted padtemplate strings now btw... anything else that needs to be done here?
Actually, it should probably be fixed in the debugs, but changing the pad names would break the API and that would be a bit annoying.
Right, let's just fix this for 0.11 then.
0.11 -> marking as enhancement