After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 500324 - Desktop appearance capplet page should suggest colours that you can set your background to
Desktop appearance capplet page should suggest colours that you can set your ...
Status: RESOLVED OBSOLETE
Product: gnome-control-center
Classification: Core
Component: Background
git master
Other All
: Normal enhancement
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-11-29 00:37 UTC by iain
Modified: 2012-05-04 18:27 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
gzipped patch to implement (24.72 KB, application/octet-stream)
2007-11-29 00:39 UTC, iain
Details

Description iain 2007-11-29 00:37:46 UTC
When you go to buy paint you pick a colour and then look at the colour swatches to find a colour that goes well with the colour you have choosen. The background capplet could use the same technology to make suggestions for the second colour when you have a gradient selected.

Attached is a patch that does just that.
Comment 1 iain 2007-11-29 00:39:34 UTC
Created attachment 99815 [details]
gzipped patch to implement
Comment 2 Teppo Turtiainen 2007-11-29 18:32:34 UTC
How are the colors generated? Agave (http://home.gna.org/colorscheme/) offers 6 different types of color schemes. What if I want my colors monochromatic?
Comment 3 iain 2007-11-30 14:40:10 UTC
(In reply to comment #2)
> How are the colors generated? Agave (http://home.gna.org/colorscheme/) offers 6
> different types of color schemes. What if I want my colors monochromatic?

The colour generation code is based on the Agave code. The first two colours are monochromatic (although I suspect they're not working right), colours 3 & 4 are the analogous colours, colour 5 is the complimentary colour, 6 & 7 are the split complimentary and 8, 9 and 10 are the 3 tetradic complimentary colours. (And I seem to have left out the triadic by accident...)

This patch isn't a "Here's every single colour that might work with your chosen base colour" solution, that would be insane. Its more a "Here's some colours that work with your base colour that you can tweak to your liking" solution.

Comment 4 Teppo Turtiainen 2007-11-30 16:38:28 UTC
(In reply to comment #3)
> The first two colours are monochromatic (although I suspect they're not working
> right)

I haven't tried out the patch, but according to the screenshot on http://blogs.gnome.org/iain/2007/11/29/all-the-colours/ they aren't.

> This patch isn't a "Here's every single colour that might work with your chosen
> base colour" solution, that would be insane. Its more a "Here's some colours
> that work with your base colour that you can tweak to your liking" solution.

The reason I asked was that I think this would only work if the user gets to choose the type of the color scheme but we obviously don't want jargon like "split compliments" in the UI. But if the patch automatically generates matching colors for many/all different types of color schemes then it would be OK.
Comment 5 iain 2007-11-30 17:29:08 UTC
(In reply to comment #4)
> I haven't tried out the patch, but according to the screenshot on
> http://blogs.gnome.org/iain/2007/11/29/all-the-colours/ they aren't.

Yes, I checked the code with how agave is doing it, and they're the same. I'll need to look into it more.

> > This patch isn't a "Here's every single colour that might work with your chosen
> > base colour" solution, that would be insane. Its more a "Here's some colours
> > that work with your base colour that you can tweak to your liking" solution.
> 
> The reason I asked was that I think this would only work if the user gets to
> choose the type of the color scheme but we obviously don't want jargon like
> "split compliments" in the UI. 

No, thats why it only shows the colours. Its less about choosing the type of colour scheme and more about being shown a selection of colours that might look nice. I don't think the user would really care if the colour was generated from a tetradic colour scheme or from a monochromatic one. All they want to do is pick a colour that looks nice.
Comment 6 Jens Granseuer 2007-11-30 17:33:11 UTC
Unfortunately, the patch doesn't apply cleanly against trunk. Looks nice, though.
Comment 7 iain 2007-11-30 17:35:53 UTC
(In reply to comment #6)
> Unfortunately, the patch doesn't apply cleanly against trunk. Looks nice,
> though.

Oh, it doesn't? My apologies, I thought I was running against trunk. Its probably because I had to change the glade file :/
I'll make a new patch when I get some time
Comment 8 Jens Granseuer 2007-11-30 17:46:39 UTC
Doesn't look like the glade changes. Oh, and regarding the glade file, it would be nice if you could isolate the modifications that are required for your patch instead of the one huge swath it is now. Glade likes to insert subtle bugs in this way...
Comment 9 Teppo Turtiainen 2007-11-30 18:26:00 UTC
(In reply to comment #5)
> No, thats why it only shows the colours. Its less about choosing the type of
> colour scheme and more about being shown a selection of colours that might look
> nice. I don't think the user would really care if the colour was generated from
> a tetradic colour scheme or from a monochromatic one. All they want to do is
> pick a colour that looks nice.

Sorry, I wasn't very clear previously. I agree that it should only show the colors and I'm not suggesting that the user should be able to select the type of the color scheme. All I'm saying is that the "selection of colours that might look nice" should include all colors that might look nice. If the user thinks that monochromatic colors look nice (and the user obviously doesn't need to know what they are called to think that) and the selection only contained for example complements, triads and analogous colors, the user would be pissed off.
Comment 10 Bastien Nocera 2011-02-11 13:21:00 UTC
Patch still needs updating.
Comment 11 Bastien Nocera 2011-02-11 13:21:27 UTC
And a screenshot attached to this bug, or some explanations as to the UI changes would be nice too.
Comment 12 Bastien Nocera 2012-05-04 18:25:15 UTC
We will likely be using a black backdrop to user-selected pictures by default in the future, so no need for that.
Comment 13 Ray Strode [halfline] 2012-05-04 18:27:50 UTC
Ryan did something to gnome-desktop recently to look at the wallpaper and find complimentary colors. see bug 671750