Bug 500179 – Missing X11 link flags

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 500179 - Missing X11 link flags


Summary:	Missing X11 link flags


Status:	RESOLVED FIXED

Product:	bug-buddy
Classification:	Deprecated
Component:	general
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	---
Assigned To:	Bug-buddy Maintainers
QA Contact:	Bug-buddy Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2007-11-28 12:30 UTC by Loïc Minier
Modified:	2008-08-31 11:21 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Require X11; link gnome-bp to X11 libs (1.48 KB, patch) 2007-11-28 12:45 UTC, Loïc Minier	none	Details \| Review
Require X11; link gnome-bp to X11 libs; v2 (1.64 KB, patch) 2007-11-28 13:35 UTC, Loïc Minier	rejected	Details \| Review

Description Loïc Minier 2007-11-28 12:30:49 UTC

Hi,

When building with -z defs in LDFLAGS:
.libs/gnome-breakpad.o: In function `release_grabs':
/home/lool/svn/gnome/bug-buddy/gnome-breakpad/gnome-breakpad.cc:184: undefined reference to `XUngrabServer'

Seems breakpad needs X11 but doesn't link to it.

Bye,

Comment 1 Loïc Minier 2007-11-28 12:45:29 UTC

Created attachment 99770 [details] [review]
Require X11; link gnome-bp to X11 libs

Comment 2 Loïc Minier 2007-11-28 13:35:17 UTC

Created attachment 99774 [details] [review]
Require X11; link gnome-bp to X11 libs; v2

Patches the proper place now; friendlier for the days where USE_GOOGLE_BREAKPAD might be false too.

Comment 3 André Klapper 2008-07-14 18:38:16 UTC

just committed the patch in bug 535098 - please feel free to contradict. :-D

Comment 4 Cosimo Cecchi 2008-08-31 11:21:26 UTC

I committed a different fix to trunk, removing direct calls to the X api and replacing them with the gdk_x11 equivalent function.
This allows do not mention directly x11 in the configure script and rely on Gdk doing the magic.
Please reopen and complain if there's still something wrong with this solution.

2008-08-31  Cosimo Cecchi  <cosimoc@gnome.org>

	* configure.in:
	* gnome-breakpad/gnome-breakpad.cc:
	Replace a direct call to X API with gdk_x11, and do not specify x11
	anymore as a required module in the configure script.
	Removed a bit of duplicate code.
	This should also fix bug #500179.