After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 499339 - .gnumeric I/O for explicit page breaks.
.gnumeric I/O for explicit page breaks.
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Main System
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2007-11-24 12:54 UTC by Jody Goldberg
Modified: 2007-11-25 17:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
implementation (11.50 KB, patch)
2007-11-24 12:56 UTC, Jody Goldberg 		committed Details | Review

Description Jody Goldberg 2007-11-24 12:54:50 UTC 
A patch to fix sax import, implement DOM import and sax export.
Comment 1 Jody Goldberg 2007-11-24 12:56:34 UTC 
Created attachment 99571 [details] [review]
implementation

Tested.  First in a series of .gnumeric and .xlsx related patches.
Please review.
Comment 2 Morten Welinder 2007-11-24 16:02:41 UTC 
I don't like gnm_page_break_type_from_str.  If it is really necessary, then
just grant it access to the values currently inside gnm_page_break_type_get_type
instead of having the strings twice.  Or thrice if you count xml_write_breaks.

Maybe the speed problem could be solved by having xml_sax_attr_enum take
a eclass instead of an etype.
Comment 3 Jody Goldberg 2007-11-25 17:29:50 UTC 
removed the _type_get_type enum registration entirely.  No significant utility foreseeable right now.