GNOME Bugzilla – Bug 498095
Duplicate mnemonics
Last modified: 2009-10-13 09:37:22 UTC
https://bugzilla.novell.com/show_bug.cgi?id=8805 Steps to reproduce the problem: 1. Click Calendar. 2. Right click Personal in the Lefthand taskpane. 3. Click Properties Duplicate Hotkey "O"
https://bugzilla.novell.com/show_bug.cgi?id=8886 Triplicate Hotkey "C" in Contact Editor window. Steps to reproduce the problem: 1. Click Programs->Novell Evolution. 2. Click Contacts 3. Click New
https://bugzilla.novell.com/show_bug.cgi?id=8782 Duplicate hotkey in New VFolder dialog for all Add and Remove options.
https://bugzilla.novell.com/show_bug.cgi?id=8780 Duplicate hotkey R in Advanced Search dialogue 1.Search > Advanced Search 2.Click Add button. Triple or more hotkey R for Remove button
https://bugzilla.novell.com/show_bug.cgi?id=8844 Steps to reproduce the problem: 1. Right click on message 2. Select Mark for follow up Duplicate Hotkey "C" found
https://bugzilla.novell.com/show_bug.cgi?id=8808 Duplicate Hotkey "C" found in Edit Categories window when creating a new task. Steps to reproduce the problem: 1. Click Tasks. 2. Click New Task 3. Click Categories.
https://bugzilla.novell.com/show_bug.cgi?id=8783 hotkey Alt s does not function on Add Alarm dialogue 1. Select New and All Day Appoinment 2. Click on Alarm select Customize option 3. Click on the Add button 4. Enable the checkbox for Custom Message
https://bugzilla.novell.com/show_bug.cgi?id=8851 Duplicate Hotkeys "R" and "A" found when creating a search folder 1. Menu bar > Edit > Search folder 2. Click Add
https://bugzilla.novell.com/show_bug.cgi?id=8729 1. Menu bar > New > Contact List W - Where hotkey does not function.
https://bugzilla.novell.com/show_bug.cgi?id=8825 Steps to reproduce the problem: 1. Menu bar > New > Mail Folder There is no hotkey present for Create
Created attachment 100053 [details] [review] https://bugzilla.novell.com/show_bug.cgi?id=8886 Patch to fix https://bugzilla.novell.com/show_bug.cgi?id=8886 (The triple C mnemonic clash)
Created attachment 100054 [details] [review] https://bugzilla.novell.com/show_bug.cgi?id=8805 Patch for https://bugzilla.novell.com/show_bug.cgi?id=8805 (The o mnemonic clash) (N.B. this isn't the patch I mentioned on the GHOP issue 14, the other one is)
You know, bug reference in ChangeLog. The first is fine, can commit to trunk. The second, it's not so easy, different calendar types has different options. For example, On The Web calendar has option "_Refresh". BTW, are you going to produce patch for all issues in this bug? If yes, it will be better to have one patch for all of them in one, not couple of small partial patches for one bug. Thanks.
Committed to SVN trunk as r34810 (http://svn.gnome.org/viewvc/evolution?view=revision&revision=34810)
Created attachment 103410 [details] screenshot see mnemonics for 'Edit' menu and 'Description' - also check if the same bug exists in task and memo editors. If it does, please fix it. Else, make the hotkeys uniform.
Bumping version to a stable release.
Created attachment 116360 [details] [review] Fix mnemonic clash in new appointment, new task Fixing mnemonics clashes with "_Edit", as well as making sure new mnemonics are consistent across dialogs and don't produce new clashes.
Looks good, I'll commit to trunk and announce a string change after a little test.
A little bit extended patch from comment #16 committed to trunk. Committed revision 35965. The only thing I realized was the mnemonic_widget wasn't set for description label in memo-page, so I fixed this together with your changes. I hope it's fine. By the way, thanks for the patch.
So what's left for this bug? Can someone summarize?
Issues mentioned in comment 3, 4, 5, 6, 8 are still valid against 2.28.0
comment #3 - CantFix, it's better to have a duplicate hotkey than none; note the buttons are generated based on the conditions count; There is something similar in a contact search dialog (when you hit "To:" button in a composer), it have been left there intentionally for the same reason. comment #4 - done in evo comment #5 - done in eds comment #6 - done in evo comment #8 - done in evo Created commit 5652aa2 in eds master (2.29.1+) Created commit dc29530 in evo master (2.29.1+)