GNOME Bugzilla – Bug 497517
Transactions set to 'c' in the R(econciled) field of the register are incorrectly set to 'n' when postponing a reconciliation
Last modified: 2018-06-29 21:54:30 UTC
Please describe the problem: When doing a reconciliation all transactions after the statement date are not auto-checked in the reconciliation window (even though they may to be set to 'c' in the register). If the reconciliation is postponed, all transactions without a checkmark in the reconciliation dialog are set to 'n' in the register. This means all the data for cleared transactions after the statement date is lost. Steps to reproduce: 1. Create a few transactions with different dates and set them all to 'c' in the register (make sure that "Check Cleared Transactions" is selected in the Register preferences). 2. Click on "Reconcile" and pick a statement date before the date of at least one of the transactions. 3. Click "Postpone" in the reconciliation window. Actual results: When the reconciliation is postponed any transactions that were not checked in the reconciliation window (which will be all transactions after the statement date) will be set to 'n' in the register (even if there had been set to 'c' before). Expected results: I would expect the transactions after the statement date to remain unchanged, unless I explicitly changed their values (e.g. checked off one of the transactions after the statement date). Does this happen every time? Yes Other information:
Created attachment 99229 [details] [review] Patch to reconcile-list.h and reconcile-list.c
Comment on attachment 99229 [details] [review] Patch to reconcile-list.h and reconcile-list.c I have created a simple patch for this issue. When postponing a reconciliation it checks if the transaction occurs after the statement date. If it does then the value of the transaction in the register is only changed if the transaction has been marked as cleared (checked off) in the reconciliation window. This means that transactions after the statement date can only be changed from 'n' to 'c' (assumes that if user checks off a transaction they want it set to 'c' in the register).
Created attachment 100369 [details] [review] improvement to the first patch, initializes new field Hi Jeff, I've noticed the time_t statement_date field that the patch in comment #1 adds to struct GNCReconcileList (src/gnome/reconcile-list.h). I see where you use it in in gnc_reconcile_list_postpone() (src/gnome/reconcile-list.c) when comparing against xaccTransGetDate(xaccSplitGetParent(split)). What seems to be missing is the setting of this new field to a particular value. I've attached a modified version of you patch that does this in gnc_reconcile_list_new.
Applied to trunk as r16726. Awaiting backport to 2.2.
branches/2.2 @ r16789 for GnuCash 2.2.3. Thanks a lot!
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=497517. Please update any external references or bookmarks.