After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 487970 - [upnp] Provide nice icon
[upnp] Provide nice icon
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Plugins (other)
unspecified
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-10-18 17:20 UTC by Bastien Nocera
Modified: 2007-12-10 10:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rb-upnp-add-icon.patch (954 bytes, patch)
2007-12-07 12:06 UTC, Bastien Nocera 		none Details | Review
rb-upnp-add-icon-2.patch (1.03 KB, patch)
2007-12-07 13:39 UTC, Bastien Nocera 		none Details | Review
rb-upnp-add-icon-3.patch (1.51 KB, patch)
2007-12-07 14:23 UTC, Bastien Nocera 		committed Details | Review
proof (362.77 KB, image/jpeg)
2007-12-07 14:24 UTC, Bastien Nocera 		  Details

Description Bastien Nocera 2007-10-18 17:20:23 UTC 
In the PS3's interface, I can see that Windows Media Player has a custom icon for their sources. It would be nice if Rhythmbox could advertise itself with its own icon as well.
Comment 2 Bastien Nocera 2007-12-07 12:06:52 UTC 
Created attachment 100514 [details] [review]
rb-upnp-add-icon.patch
Comment 3 Bastien Nocera 2007-12-07 13:39:34 UTC 
Created attachment 100521 [details] [review]
rb-upnp-add-icon-2.patch

Patch that should actually work
Comment 4 Bastien Nocera 2007-12-07 14:23:47 UTC 
Created attachment 100523 [details] [review]
rb-upnp-add-icon-3.patch

And one that actually works.
Comment 5 Bastien Nocera 2007-12-07 14:24:20 UTC 
Created attachment 100524 [details]
proof
Comment 6 James "Doc" Livingston 2007-12-08 02:36:42 UTC 
Looks fine to me, feel free to commit.
Comment 7 Bastien Nocera 2007-12-10 10:36:04 UTC 
2007-12-10  Bastien Nocera  <hadess@hadess.net>

        * plugins/coherence/upnp_coherence/__init__.py: Export the
        user's ~/.face (as setup by about-me and gdmphotosetup)
        as the server's icon, for display in clients that support
        it (Closes: #487970)