After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 486346 - gok-1.3.6 fails to build with XEViE support enabled
gok-1.3.6 fails to build with XEViE support enabled
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: build
1.3.x
Other Linux
: High major
: ---
Assigned To: Joseph Sacco
David Bolter
: 486304 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-13 15:38 UTC by Joseph Sacco
Modified: 2007-10-14 20:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Joseph Sacco 2007-10-13 15:38:52 UTC 
gok-1.3.6 fails to compile on a PPC running Fedora FC7 when XEViE support is enabled. gok-1.3.5 compiles just fine on this machine which has libXevie-1.0.2 and libXevie-devel-1.0.2 installed.

The problem arises from changes to ./gok/main.c.  A proposed fix is shown below.

-Joseph

=============================================================================
--- gok-1.3.6/gok/main.c-   2007-10-13 11:32:59.000000000 -0400
+++ gok-1.3.6/gok/main.c    2007-10-13 11:33:44.000000000 -0400
@@ -1228,6 +1228,7 @@
                   gpointer data)
 {
 #ifdef HAVE_XEVIE
+   XEvent xevie_event;
     while (xevie_dpy && XPending (xevie_dpy)) {
       XMotionEvent *motion_event;
       gboolean has_active_key = gok_scanner_key_is_active ();
Comment 1 David Bolter 2007-10-13 16:33:14 UTC 
Thanks Joseph. That compile path wasn't tested with the latest patch and I'm glad you caught it early!

Do you have commit privs?  If so, can you please commit this fix asap? Otherwise I'll commit tonight or tomorrow.
Comment 2 Joseph Sacco 2007-10-13 17:00:35 UTC 
David,

You are welcome.  I have never attempted to update another project other than GARNOME so it would probably be best if you were to commit the patch.

-Joseph
Comment 3 David Bolter 2007-10-13 17:36:01 UTC 
Reassigned bug to Joseph and resolved as fixed via checking revision 2452.

2007-10-13  David Bolter  <david.bolter@utoronto.ca>
	* gok/main.c: (gok_main_xevie_io): Added variable declaration.
	Thanks for fix Joseph Sacco, fixes bug #486346.
Comment 4 Götz Waschk 2007-10-14 20:38:12 UTC 
*** Bug 486304 has been marked as a duplicate of this bug. ***