After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 484666 - libcroco-0.6 header file cr-fonts.h should be included just once.
libcroco-0.6 header file cr-fonts.h should be included just once.
Status: RESOLVED FIXED
Product: libcroco
Classification: Core
Component: General
0.6
Other All
: Normal normal
: ---
Assigned To: libcroco maintainers
libcroco maintainers
: 485532 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-10-08 10:52 UTC by Ghee Teo
Modified: 2007-10-11 07:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Ghee Teo 2007-10-08 10:52:07 UTC 
Please describe the problem:
  /usr/include/libcroco-0.6/libcroco/cr-fonts.h is wrong.
This header should be included just once.
It needs an #ifndef wrapper around all its other contents.

Steps to reproduce:
1. Try to build app that include the cr-fonts.h more than once.
2. 
3. 


Actual results:
multiple functions declaration.

Expected results:
should not complain about the functions defined in this header file,

Does this happen every time?
yes

Other information:
Comment 1 Benjamin Dauvergne 2007-10-08 13:13:08 UTC 
I don't really understand your problem because in the last svn version
I can clearly see this at the beginning and end of cr-fonts.h:
-=-=-
#ifndef __CR_FONTS_H__
#define __CR_FONTS_H__
<SNIP>
#endif
-=-=-
So how is it possible that it is included multiple times in your environment ?
Comment 2 Ghee Teo 2007-10-08 14:56:54 UTC 
Hi Benjamin,
Hmm, I just checked svn trunk. you are absolutely correct!
I must have an older tarball version of the release which does not this change.

It seems that this is fixed in trunk but still is in the 0.6 trunk.

http://svn.gnome.org/viewcvs/libcroco/branches/libcroco-0-6-0/src/cr-fonts.h?view=annotate

and since we uses tarball releases and hence seeing the problem.

Any chance of releasing a new tarball soon?

Anyway, feel free to close this bug :)

Thanks for you prompt response!

-Ghee
Comment 3 Benjamin Dauvergne 2007-10-08 21:14:10 UTC 
Ok I'll fill a ticket for a new release.
Comment 4 Ghee Teo 2007-10-09 10:28:43 UTC 
THANKS! :)
Comment 5 Benjamin Dauvergne 2007-10-11 07:05:00 UTC 
*** Bug 485532 has been marked as a duplicate of this bug. ***
Comment 6 Benjamin Dauvergne 2007-10-11 07:06:46 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.