After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 481374 - stream not getting unref'd
stream not getting unref'd
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: playback
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-28 17:40 UTC by John Bryant
Modified: 2007-09-30 06:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This would fix it, if necessary. (696 bytes, patch)
2007-09-28 17:45 UTC, John Bryant 		committed Details | Review

Description John Bryant 2007-09-28 17:40:59 UTC 
I could be wrong about this, but in link_unblocked_cb (in backends/gstreamer/rb-player-gst-xfade.c), the stream parameter should be unreferenced before the function exits, since a reference is added before the function is called.  In the case where the function is called twice, it exits without calling g_object_unref.

Since I can't reproduce the situation in which link_unblocked_cb is being called twice, I can't tell if I'm right, but I thought someone might like to know.
Comment 1 John Bryant 2007-09-28 17:45:26 UTC 
Created attachment 96335 [details] [review]
This would fix it, if necessary.
Comment 2 Jonathan Matthew 2007-09-30 06:37:32 UTC 
I don't know how to reproduce this either, but the patch appears correct to me, so I've committed it.  Thanks.