After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 479507 - Add an option to build without google-breakpad
Add an option to build without google-breakpad
Status: RESOLVED FIXED
Product: bug-buddy
Classification: Deprecated
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Bug-buddy Maintainers
Bug-buddy Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-23 12:24 UTC by Sjoerd Simons
Modified: 2008-09-24 16:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (2.32 KB, patch)
2007-09-23 12:27 UTC, Sjoerd Simons
none Details | Review

Description Sjoerd Simons 2007-09-23 12:24:57 UTC
Hi,

  The patch i'll attach in a bit adds a configure time switch to not build   
  with google-breakpad (even if your arch supports it). Also it makes bug-buddy
  only configure and include files from google-breakpad if google-bp support is
  turned on.

  for the record.. This is because in debian we don't want to build with 
  google-breakpad support as parts of it are under the apache license which is 
  incompatible with GPLv2 (bug-buddy's license). But thats an issue for another
  bug :).. Apart from licensing issues, building without google-breakpad should
  be quite usefull for testing too.
Comment 1 Sjoerd Simons 2007-09-23 12:27:38 UTC
Created attachment 96055 [details] [review]
proposed patch
Comment 2 Fernando Herrera 2007-09-24 19:23:31 UTC
Hi, thanks for the patch.

I'm quite interested about the licensing issues.

google-breakpad page [1] stands that it is under New BSD License, and that is what I understood from google developers.

The only reference that I can find in the current code about APL is in postfix_evaluator.h and probably is a mistake.


[1] http://code.google.com/p/google-breakpad/
Comment 3 Cosimo Cecchi 2008-09-01 13:44:35 UTC
I will commit this after branching for gnome-2-24.
Comment 4 Cosimo Cecchi 2008-09-24 16:34:42 UTC
I committed a slightly modified version of this patch to trunk, closing as FIXED.

2008-09-24  Cosimo Cecchi  <cosimoc@gnome.org>

	* configure.in:
	Make google-breakpad support optional (but enabled by default for
	the platforms that support it).
	Thanks to Sjoerd Simons (#479507).