After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 478303 - Image load preference no longer working
Image load preference no longer working
Status: RESOLVED FIXED
Product: galeon
Classification: Deprecated
Component: Mozilla interaction
2.0.3
Other Linux
: Normal normal
: ---
Assigned To: galeon-maint
galeon-maint
Depends on:
Blocks:
 
 
Reported: 2007-09-19 10:40 UTC by Denis Leroy
Modified: 2007-09-20 15:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fixes the image load preference (2.68 KB, patch)
2007-09-19 11:22 UTC, Denis Leroy 		none Details | Review
Fixes the image load preference (2.68 KB, patch)
2007-09-19 11:22 UTC, Denis Leroy 		none Details | Review
Fixes image load preference (2.17 KB, patch)
2007-09-19 16:39 UTC, Denis Leroy 		none Details | Review

Description Denis Leroy 2007-09-19 10:40:18 UTC 
The image load preference (View -> Images -> Always/Never) no longer works.

The reason is that the mozilla configuration key name changed from Network.image.imageBehavior to permissions.default.image.
Comment 1 Denis Leroy 2007-09-19 11:22:25 UTC 
Created attachment 95840 [details] [review]
Fixes the image load preference

Please find attached patch which fixes the mozilla configuration key for the Image Load Preference, as well as the key value mapping.
Comment 2 Denis Leroy 2007-09-19 11:22:25 UTC 
Created attachment 95841 [details] [review]
Fixes the image load preference

Please find attached patch which fixes the mozilla configuration key for the Image Load Preference, as well as the key value mapping.
Comment 3 Denis Leroy 2007-09-19 11:24:51 UTC 
Sorry for the attachment dupe, bugzilla.gnome.org is horribly broken and slow today.
Comment 4 Yanko Kaneti 2007-09-19 11:25:10 UTC 
yep. see svn revision 8909

*** This bug has been marked as a duplicate of 347346 ***
Comment 5 Denis Leroy 2007-09-19 12:02:02 UTC 
No, the fix in SVN is incorrect.

You only changed the key name. The kep value mapping changed as well. See  http://kb.mozillazine.org/Permissions.default.image. Check my patch, which I already pushed upstream to Fedora and is well tested.

I changed the implementation of radio_group_set_from_value() so that it doesn't depend on the ordering of the GtkRadioActionEntry arrays.
Comment 6 Yanko Kaneti 2007-09-19 13:44:05 UTC 
I see. Well, perhaps if the patch is redone for svn using the versioning defines philipl won't mind somebody committing it.
Comment 7 Denis Leroy 2007-09-19 16:39:35 UTC 
Created attachment 95856 [details] [review]
Fixes image load preference

Here's the reworked patch, based on svn trunk :-)
Comment 8 Philip Langdale 2007-09-20 15:14:00 UTC 
Thanks. Now checked in.