After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 477569 - More arrow issues: Arc arrows are not considered for bounding box
More arrow issues: Arc arrows are not considered for bounding box
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
0.96.1
Other Windows
: Normal normal
: 0.97
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks: 475168
 
 
Reported: 2007-09-16 19:36 UTC by Hans Breuer
Modified: 2008-04-26 17:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Hans Breuer 2007-09-16 19:36:54 UTC 
Every arrow in row two of samples/arrows.dia exceeds the bounding box. The code in objects/standard/arc.c calls connection_update_boundingbox() which in turn calls line_bbox(). This is not correct because it does not consider the almost always different directions arrows on an arc point to,
Comment 1 Hans Breuer 2007-09-22 12:16:08 UTC 
My big arrow refactoring starts to look promising. Stay tuned;)
Comment 2 Hans Breuer 2008-04-26 17:00:23 UTC 
Again fixed by:

2007-10-06  Hans Breuer  <hans@breuer.org>

	* lib/arrows.c : major restructuring - getting calculate and draw by
	function pointer. A lot of arrows are converted to the new style thus
	arrow_bbox() can give the correct bounding box.
	* objects/standard/arc.c : bug #340705 and bug #477569
	  objects/standard/bezier.c : bug #300055 
	  objects/standard/line.c objects/standard/polyline.c 
	  objects/standard/zigzagline.c : not using *BBExtra to adjust the 
	bounding box for arrows but instead a combination of arrow_bbox()
	and calculate_arrow_point()