After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 474969 - [neonhttpsrc] fails to play radio streams with neon >=0.26
[neonhttpsrc] fails to play radio streams with neon >=0.26
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.5
Other All
: Normal normal
: 0.10.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-08 21:01 UTC by Thomas Green
Modified: 2007-09-09 19:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Output from gst-launch (3.35 KB, text/plain)
2007-09-08 21:02 UTC, Thomas Green
  Details
Patch against gst-plugins-bad-0.10.5 that sets the required session flag if using neon >=0.26 (483 bytes, patch)
2007-09-08 21:04 UTC, Thomas Green
committed Details | Review

Description Thomas Green 2007-09-08 21:01:21 UTC
Please describe the problem:
The 0.26 series of the neon library introduced session flags. One of these (NE_SESSFLAG_ICYPROTO) is now used to add support for non-HTTP ShoutCast-style "ICY" responses and the neonhttpsrc plugin won't play any internet radio streams without this being set.

Steps to reproduce:
1. gst-launch -m neonhttpsrc neon-http-debug=true location="http://rp.changeip.com:8001" ! decodebin ! audioconvert ! audioresample ! alsasink


Actual results:
The radio stream does not play and gst-launch exits.

Expected results:
The radio stream should begin playing.

Does this happen every time?
Yes

Other information:
I will attach the output I get from the gst-launch command and my attempt at a patch.
Comment 1 Thomas Green 2007-09-08 21:02:05 UTC
Created attachment 95190 [details]
Output from gst-launch
Comment 2 Thomas Green 2007-09-08 21:04:09 UTC
Created attachment 95191 [details] [review]
Patch against gst-plugins-bad-0.10.5 that sets the required session flag if using neon >=0.26
Comment 3 Tim-Philipp Müller 2007-09-09 19:07:40 UTC
Indeed, guess no one noticed because everyone is using gnomevfssrc for these streams. In any case: thanks for the patch! Committed to -bad CVS:

 2007-09-09  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Thomas Green  <tom78999 gmail com>

        * ext/neon/gstneonhttpsrc.c:
          With libneon 2.6, we need to set the NE_SESSFLAG_ICYPROTO
          flag if we want ICY streams to be handled too, otherwise
          libneon will error out with a 'can't parse reponse' error.
          Fixes #474696.

        * tests/check/elements/neonhttpsrc.c:
          Unit test for the above by Yours Truly.