After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 474308 - Same accelerator for multiple choices
Same accelerator for multiple choices
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: [obsolete] Preferred applications
2.19.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-09-06 18:26 UTC by Daniel Nylander
Modified: 2007-09-22 13:57 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20

Attachments
Fixes accelerators for a11y (1.27 KB, patch)
2007-09-18 12:13 UTC, Patrick Wade 		committed Details | Review

Description Daniel Nylander 2007-09-06 18:26:38 UTC 
There are more than one choice when using the accelator key

See http://www.gnome.org/start/2.20/notes/C/figures/rnusers-control-panel-preferred-apps-accessibility.png

#: ../capplets/default-applications/gnome-default-applications-properties.glade.h:22
msgid "Run at st_art"


Alt+M (choosing Command) does not work (which is also double)

(gnome-default-applications-properties:18573): Gtk-CRITICAL **: gtk_widget_event: assertion `WIDGET_REALIZED_FOR_EVENT (widget, event)' failed


Other information:
Comment 1 Patrick Wade 2007-09-18 12:13:57 UTC 
Created attachment 95791 [details] [review]
Fixes accelerators for a11y
Comment 2 Patrick Wade 2007-09-18 12:14:34 UTC 
Makes the accessibility accelerators unique.
Comment 3 Jens Granseuer 2007-09-18 19:14:33 UTC 
Thanks, fixed in trunk.

2007-09-18  Jens Granseuer  <jensgr@gmx.net>

        Patch by: Patrick Wade <patrick.wade@sun.com>
                                                   
        * gnome-default-applications-properties.glade: make accelerators for
        the accessibility tools page unique (bug #474308)
Comment 4 Rodrigo Moya 2007-09-18 23:14:53 UTC 
This should also be fixed in the 2.20 branch, right?
Comment 5 Jens Granseuer 2007-09-19 15:58:36 UTC 
Guess so. What's the process? String freeze is still in effect, isn't it?
Comment 6 Rodrigo Moya 2007-09-19 18:02:30 UTC 
AFAIK these kind of changes are allowed, but to be 100% sure, send the patch to release-team@ and get approval from them
Comment 7 Jens Granseuer 2007-09-22 13:57:53 UTC 
String freeze break was not approved. Talked to Danilo on IRC, and he believes this change is not important enough to break translations. Punting to 2.22 for that reason.