GNOME Bugzilla – Bug 472862
Port custom report: reports/patch-report.cgi
Last modified: 2015-01-02 17:05:26 UTC
This reports needs to be ported to Bugzilla 3.0 or newer. The following are related: * reports/patch-status.cgi If you are interested, please say so and I'll add more detail.
Created attachment 140967 [details] [review] straight port This is a direct port, do note it also merges patch-report-utils.pl in the cgi, as it was the only user of the only method defined in that file. Also, just like the points.cgi, it is set at the web root because CSS files are currently set with relative paths.
Created attachment 141058 [details] Patch Report Extension Port of the patch report to a proper extension, the URL would look like: http://bugzilla.gnome.org/page.cgi?id=patchreport.html&product=TestProduct&patch-status=accepted-commit_now
Could this be reviewed? This report is quite useful in time of releases...
For everybody's information, my contract with Canonical only has me fixing bugs at this point, not implementing any new enhancements or doing any reviews on any enhancements. I could choose to do reviews or enhancements in my own time, but usually if I'm going to do that I work on upstream Bugzilla, because I have always had more work to do there than I can actually do. So for now, if enhancements to bugzilla.gnome.org are going to be reviewed, they should be reviewed by somebody other than me.
Created attachment 143060 [details] Patch Report Extension Checked against latest bugzilla.gnome.org repos (updated to bz 3.4.2), and a few minor stylistic changes (removing trailing spaces, replacing some tabs by spaces...). Olav, could you check it works on the real bugzilla server? Then I will amend browse.cgi to add links.
Created attachment 143062 [details] [review] Extension as a diff This handles the submitter query parameter correctly.
http://bazaar.launchpad.net/~bgo-maintainers/bugzilla.gnome.org/3.4/revision/6686 Committed, takes a while before I can check it out on the server.
Server has been updated. We still need to add more security checks though. Check bug can be accessed as well as the attachment. That is for a follow up bug.