GNOME Bugzilla – Bug 472647
style properties in message area
Last modified: 2009-01-01 15:49:14 UTC
i will attach a patch for this.
Created attachment 94775 [details] [review] style properties for message area There were some FIXME comments in message area. This patch fix that feature request.
Created attachment 94799 [details] [review] message area Corrected a Gtranslator instead of Gedit data type
Comment on attachment 94799 [details] [review] message area >+#define GTK_PARAM_READABLE G_PARAM_READABLE|G_PARAM_STATIC_NAME|G_PARAM_STATIC_NICK|G_PARAM_STATIC_BLURB You should not define anything in the GTK_ namespace... Why not use G_PARAM_READABLE|G_PARAM_STATIC_STRINGS directly? >+ update_spacings(message_area); There is a missing space here. Also, since it's the only place this function is called, why not putting it inline here directly?
Maybe I'm confused but I think there is something wrong in the patch. To change the space between buttons you should change the spacing of action_area not main_hbox. To set the content-area-border style property you should change the border of the "contents" not of the main_hbox (this could be a bit tricky to implement). I suggest you to look at GtkDialog implementation to see how the properties are set there. See also comment #3 by Steve.
Created attachment 103490 [details] [review] patch What about this?
Created attachment 103491 [details] [review] message-area I forgot a variable
If we want this we can always resurrect this bug. Marking this as obsolete.