After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 470672 - Totem lirc plugin missing two of the three seek velocities
Totem lirc plugin missing two of the three seek velocities
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Plugins
2.19.x
Other Linux
: Normal major
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-08-27 12:14 UTC by Benjamin Drung
Modified: 2008-08-21 13:27 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Benjamin Drung 2007-08-27 12:14:41 UTC
In Totem you can seek with three different velocities, e.g. for seeking forward you can use right, shift+right and control+right. The lirc plugin for Totem only have a "seek_forward" option. I like to have all velocities: "seek_slow_forward", "seek_forward" and "seek_fast_forward".
Comment 1 Bastien Nocera 2007-08-27 12:29:49 UTC
I'm not sure what to do with that. I don't see remote controls having 3 different buttons for 3 different rewind/fast forward speeds, so we'd have to come up with some other way of making those 3 speeds available to the remote. Any suggestions appreciated.
Comment 2 Benjamin Drung 2007-08-27 12:46:20 UTC
I have many buttons on my remote control. The previous and next button is reserved for my audio player. So I use the numbers on my remote control for seeking:

1 = seek slow backward
3 = seek slow forward
4 = seek backward
6 = seek forward
7 = seek fast backward
9 = seek fast forward

This is my idea behind this:

       backward    forward
       -------------------
slow   |  1  |  2  |  3  |
       -------------------
normal |  4  |  5  |  6  |
       -------------------
fast   |  7  |  8  |  9  |
       -------------------
Comment 3 Carsten Luedtke 2007-09-04 11:11:25 UTC
I don't think it's needed to reserve 6 keys for this. Lirc can use key sequences, if you configure an action with multiple keys. And you can configure it per application. So its not needed to have different keys for the same action but differnent apps.

More usefull for me would be, if seek_forward and seek_backward would take an argument in seconds and maybe in percent (for really fast forward). Then it's upto the user to configure this to his own needs. Xine does the same. 

And while we are at lirc, also usefull (from a remote controls point of view) is a stop action. At this time there is no way to go back to the beginning of the playlist with a remote. The remote has the key anyway - it's just not used.
Comment 4 Bastien Nocera 2008-08-21 12:46:00 UTC
Fixed the missing stop button, which I guess is pretty useful.

2008-08-21  Bastien Nocera  <hadess@hadess.net>

	* src/plugins/lirc/totem-lirc.c (totem_lirc_to_command):
	* src/plugins/lirc/totem_lirc_default:
	* src/totem.c (totem_action_remote):
	* src/totem.h: Add support for the stop remote control key,
	will stop the playback and go back to the beginning of the playlist
	(as the stop button on a CD player would do)

	* src/backend/bacon-video-widget-gst-0.10.c (got_time_tick),
	(bacon_video_widget_stop): Don't print out warnings when trying to
	stop a stream but nothing is opened

	See http://bugzilla.gnome.org/show_bug.cgi?id=470672#c3
Comment 5 Bastien Nocera 2008-08-21 13:27:43 UTC
I added this to the example lirc file:

# For seek_forward and seek_backward you can
# append ":20" to seek 20 seconds in the
# aforementioned direction
#
# Eg. seek_forward:60 -> seek forward 60 seconds
# seek_backward:5 -> seek backwards 5 seconds

2008-08-21  Bastien Nocera  <hadess@hadess.net>

	* src/totem.c (totem_action_remote): Allow passing an
	offset for the backward/forward seeking, through the url
	parameter

	* src/plugins/lirc/totem-lirc.c (totem_lirc_get_url),
	(totem_lirc_to_command), (totem_lirc_read_code):
	Parse seek_backward and seek_forward and allow users
	to append a seek offset, meaning you can configure different
	keys for different seeking lengths

	* src/plugins/lirc/totem_lirc_default: document the above

	(Closes: #470672)