GNOME Bugzilla – Bug 469131
do not use gnome_help_display
Last modified: 2007-12-04 22:41:58 UTC
Please describe the problem: in order to remove libgnome deps call out to gnome-open ghelp directly this makes help optional and not a link dependency (similar pacthes were added to other gnome modules during the past 3 release cycles) Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 94089 [details] [review] the patch
Is that all we are using libgnome for? In that case, shouldn't the patch remove the configure.in bits too?
Created attachment 94090 [details] [review] larger patch wow what a quick repsone :) I was about to post the larger patch just in case. It was easy to do thanks to the already existing ifdef on HAVE_GNOME.
gnome_program_init() was used and until 2.20 it was the only way to initialize bug-buddy so some module maintainers were understandably reluctant to replace it with gtk_init.
Bug 140414 adds a gconf dependency, so I don't think --disable-gnome should be removed completely.
ok, had did not seen that other bugreport when I posted. The disable gnome config can stay and HAVE_GNOME will only guard gconf if it that is a better way. As long as the other larger deps are no longer around I am fine. It would be appreciated if the person commiting gconf support merges this patch after as well. thanks
or commit this one as is, and add a more descriptive disable-gconf option?
according to the last comment on the other bug that would better use --disable-gconf, so I think this patch can stay as is.
it this too late for 2.20?
I'd say yes.
please consider this for 2.22 then
Same here, Christian, is the patch ready to go on in your opinion? :P
Looks ready to me.
Updated to svn trunk, and committed. * configure.ac: * gucharmap/Makefile.am: * gucharmap/gucharmap-window.c: (help_contents): * gucharmap/main.c: (main): Remove gnome option. Bug #469131, patch by Jani Monoses.