GNOME Bugzilla – Bug 467044
Consider relaxing Bonobo dependency in pyatspi
Last modified: 2021-06-10 07:56:37 UTC
As part of the work done on bug 163132, the IOR of the at-spi-registryd process can be found via the AT_SPI_IOR string property on the root window. This helps eliminate the need to use Bonobo activation. It would be good if the pyatspi module could relax its dependency on Bonobo and use the AT_SPI_IOR property instead.
Created attachment 93744 [details] [review] Patch to use AT_SPI_IOR property and not use Bonobo This seems to work OK with accerciser as the test bed, but I suspect there might be a better way to go about this.
So is this the proposed patch?
(In reply to comment #2) > So is this the proposed patch? > It is indeed, but I think it should be considered for post GNOME 2.20 release. I'd like to see some work go into GNOME 2.22 overall to eliminate the Bonobo dependency of AT-SPI, and this could be part of it. I would also like to see some review of this patch by the pyatspi author(s). I suspect more graceful error checking probably should be added.
The patch should probably try to import use bonobo first to activate the registry. If that method fails, it should use the IOR property directly. Or vice versa. A general try/except that catches the Exception base class should do the trick.
Hi Peter, we plan to remove bonobo dependency from at-spi in GNOME 2.22. So I think the IOR way is OK.
The try/except allows pyatspi to continue to support backwards compatibility with older versions of GNOME/at-spi. If you remove it, users/distros can no longer grab the latest, bug-fixed pyatspi code and run it without updating at-spi and their entire GNOME desktop along with it.
(In reply to comment #4) > The patch should probably try to import use bonobo first to activate the > registry. If that method fails, it should use the IOR property directly. Or > vice versa. A general try/except that catches the Exception base class should > do the trick. Vice versa is the option I would go for -- we want to migrate towards elimination of Bonobo by default when possible. Just to note, though: I believe the total elimination of Bonobo from AT-SPI for GNOME 2.22 will represent a binary incompatibility and will require one to update/use the new AT-SPI infrastructure. This is a known issue with eliminating Bonobo, but there seems to be general support that the benefits outweigh the drawbacks.
[Resetting QA Contact to newly introduced "at-spi-maint@gnome.bugs". Reason: So far it was impossible to watch changes in at-spi bug reports without following all the specific persons (Li Yuan, Bill Haneman, Jeff Wai, ...) and also their activity outside of at-spi reports. IMPORTANT: Anyone interested in following all bug activity (including all maintainers) must watch the "at-spi-maint@gnome.bugs" dummy user by adding it to the 'Users to watch' list under Preferences->Email preferences. This is also the default procedure nowadays in GNOME when setting up new products.]
[Mass-resetting default assignee, see bug 705890. Please reclaim this bug report by setting the assignee to yourself if you still plan to work on this. Thanks!]
Bonobo isn't used anymore