After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 466241 - Should have mnemonics for Authentication type in preferences -> Receving mails
Should have mnemonics for Authentication type in preferences -> Receving mails
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
2.12.x
Other All
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
aklapper[mnemonics] ghop[2007-14]
Depends on:
Blocks: 324810
 
 
Reported: 2007-08-13 13:22 UTC by Lucky Wankhede
Modified: 2013-09-13 00:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
Add mnemonics to "authentication type" (1.32 KB, patch)
2007-12-02 09:28 UTC, David Turner 		needs-work Details | Review
Updated patch (2.85 KB, patch)
2007-12-03 18:15 UTC, David Turner 		committed Details | Review

Description Lucky Wankhede 2007-08-13 13:22:22 UTC 
The user should be able to directly jump to Authentication type combo box.

So having mnemonics is good idea for usability purpose..


Other information:
Comment 1 David Turner 2007-12-01 18:21:59 UTC 
Would it be acceptable to have the mnemonic on the section header, "Authentication type", or should a new label be added by the combo box?
Comment 2 David Turner 2007-12-02 09:28:46 UTC 
Created attachment 100032 [details] [review]
Add mnemonics to "authentication type"

Ok, I saw a mnemonic on a header elsewhere in evolution, so I assume it's ok.  Attached is a patch to do just that
Comment 3 Milan Crha 2007-12-03 16:50:46 UTC 
I saw somewhere a request to split into two widgets. I forgot the bug number, though. Anyway, bug reference to ChangeLog, and fix it for exchange too (plugins/exchange-operations/exchange-account-setup.c). Thanks.
Comment 4 David Turner 2007-12-03 18:15:06 UTC 
Created attachment 100129 [details] [review]
Updated patch

Updated patch
Comment 5 Milan Crha 2007-12-04 12:25:06 UTC 
Looks good to commit to trunk. I only fixed a compiler warning:
exchange-account-setup.c:852: warning: passing argument 2 of 'gtk_label_set_mnemonic_widget' from incompatible pointer type
, the second parameter should be GtkWidget.
Comment 6 Milan Crha 2007-12-04 12:25:23 UTC 
Committed to trunk. Committed revision 34643.