After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 465924 - bzip2 not built while it is present and usuable
bzip2 not built while it is present and usuable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal normal
: 1.0.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-12 10:52 UTC by Vincent Torri
Modified: 2013-08-22 13:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Vincent Torri 2007-08-12 10:52:08 UTC 
AC_CHECK_LIB (via AG_GST_CHECK_LIBHEADER) is used to detect bzip2. A generic prototype is used to check the lib (assuming the checked symbol is a cdecl function).

on linux and other unix, it's fine, but on windows, the test fails because of the decoration (@n).

I've ask an autoconf dev and he told me that the only way to check those libs on windows platform with MSYS/MinGW is to write a specific test, which includes the header and use AC_LINK_IFELSE

i don't really know how you want the check to be fixed. Maybe modifying the AG_GST_CHECK_LIBHEADER macro if it's on windows or not.
Comment 1 Sebastian Dröge (slomo) 2011-05-18 20:32:00 UTC 
IMHO the best would be to fix AG_GST_CHECK_LIBHEADER() to always use AC_LINK_IFELSE, not only on Windows. Do you want to provide a patch and is this still a problem at all?
Comment 2 Fabio Durán Verdugo 2011-06-28 23:40:05 UTC 
(In reply to comment #1)
> IMHO the best would be to fix AG_GST_CHECK_LIBHEADER() to always use
> AC_LINK_IFELSE, not only on Windows. Do you want to provide a patch and is this
> still a problem at all?

Then we can change the status to NEW.
Comment 3 Sebastian Dröge (slomo) 2013-08-22 12:57:11 UTC 
Fixed in good/bad/libav now.

commit e9581919ffec419ba3d7a22f4c10ab60ff518786
Author: Sebastian Dröge <slomo@circular-chaos.org>
Date:   Thu Aug 22 14:56:05 2013 +0200

    configure: Fix bz2 configure check for Windows
    
    Due to function decorations on Windows AC_CHECK_LIB can't be used to check for bz2.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=465924
Comment 4 LRN 2013-08-22 13:15:39 UTC 
Do note that this only applies to pristine upstream libbz2.

mingw.org patches bz2 to remove the use of stdcall convention. And THAT patch originates in Cygwin.

So both Cygwin and MinGW.org ship cdecl bz2.

I'm using that patch too, obviously.

Upstreaming this doesn't seem to be a likely prospect - for example, Debian still has to completely re-patch the whole bz2 buildsystem to use autotools properly, instead of a simple makefile; and they are usually very good at upstreaming...

Now, the change to configure is not going to break anything, so it's completely OK. This comment is mostly FYI.