Created attachment 93225 [details] [review]
Fix working on Gentoo/FreeBSD

We use this patchset on Gentoo/Linux too, so it should be safe to merge.

Hum, there is a lot of unrelated things in that patch.
It looks mostly correct, I see however one issues:
  - the change to gam_fs_init() would break on systems
    which are not Linux nor FreeBsd (Solaris, OS-X for example)
    since they won't get any initialization, need to be
    so that the dfault code continue to be used

The gam_server_get_poll_handler() looks normal, but I wonder
if this was just a typo or a late change.

Again this looks mostly okay, would you mind commenting on the
issue here or on the mailing-list so I don't forget about it (again ?)

  thanks,

Daniel

Created attachment 94059 [details] [review]
Fix Gentoo/FreeBSD

Good catch. I've added a check for the getmntinfo function to configure.in which should solve that issue.

Did you have any other queries?

I don't understand that part of the patch checking the security aspects
of the path, why did this need a change. Doesn't look like a pure portability
change:

@@ -640,9 +644,19 @@
      * some extra protection checks. Also make sure the socket is created
      * with restricted mode
      */
-    if (!gam_check_secure_path(path)) {
+    if (!gam_check_secure_dir()) {
+       close(fd);
        return (-1);
     }

can you explain ?

Daniel

Created attachment 94197 [details] [review]
Fix Gentoo/FreeBSD

No I cannot explain that. Reverting it does not stop gamin from working on Gentoo/FreeBSD either.

gamin is not under active development anymore and has not seen code changes for many years.
Its codebase has been archived: https://gitlab.gnome.org/Archive/gamin/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.