After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 464028 - Move connection-speed from playbin to playbasebin
Move connection-speed from playbin to playbasebin
Status: VERIFIED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.15
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-08-06 14:51 UTC by Josep Torra Valles
Modified: 2007-08-08 21:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to implement it (7.83 KB, patch)
2007-08-06 14:52 UTC, Josep Torra Valles 		committed Details | Review

Description Josep Torra Valles 2007-08-06 14:51:26 UTC 
Some source elements are able to deal with the connection-speed constraint directly.

So I'm proposing move connection-speed to the base class and propagate the value to source elements that also have this property implemented.
Comment 1 Josep Torra Valles 2007-08-06 14:52:49 UTC 
Created attachment 93153 [details] [review]
Patch to implement it
Comment 2 Wim Taymans 2007-08-07 14:14:52 UTC 
        Patch by: Josep Torre Valles <josep@fluendo.com>

        * gst/playback/gstplaybasebin.c: (gst_play_base_bin_class_init),
        (gst_play_base_bin_init), (queue_threshold_reached),
        (gen_source_element), (setup_substreams),
        (gst_play_base_bin_set_property), (gst_play_base_bin_get_property),
        (gst_play_base_bin_get_streaminfo_value_array):
        * gst/playback/gstplaybasebin.h:
        * gst/playback/gstplaybin.c: (gst_play_bin_class_init),
        (gst_play_bin_set_property), (gst_play_bin_get_property),
        (gst_play_bin_handle_redirect_message):
        Move connection-speed property from playbin to playbasebin so that we
        can also configure it in source elements that have the connection-speed
        property. Fixes #464028.
        Add some debug info here and there.