After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 460360 - build only modules from a moduleset
build only modules from a moduleset
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2007-07-25 19:59 UTC by Colin Walters
Modified: 2008-01-19 00:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tags build support (5.91 KB, patch)
2007-07-25 20:00 UTC, Colin Walters
none Details | Review

Description Colin Walters 2007-07-25 19:59:38 UTC
Hi,

I wanted the ability to build just "my" software from a jhbuild moduleset.  This is essentially another manifestation of the "I have all the development stuff like GTK+ installed on my system and don't want to wait a day to recompile it all" issue.

The attached patch adds the concept of "tags" to modules.  By default, modules are tagged with each moduleset they appear in.  For example, if a module name dbus-1.1 appears in the file online-desktop.modules, it gets tagged with "online-desktop".
Now, I can do:

jhbuild -m ~/src/gnome/jhbuild/modulesets/online-desktop.modules build -a --tags online-desktop online-desktop

I could have implemented support for just building a moduleset, but this seemed slightly more flexible, though perhaps we could add another command for this common case:

jhbuild -m online-desktop.modules buildmoduleset
Comment 1 Colin Walters 2007-07-25 20:00:16 UTC
Created attachment 92413 [details] [review]
tags build support

This patch also deletes a chunk of unused code in moduleset.py
Comment 2 Frederic Peters 2007-12-16 14:03:04 UTC
Sorry I didn't review it before, it somehow slipped and I forgot about it.

Patch is fine and may be commited.
Comment 3 Frederic Peters 2008-01-19 00:29:46 UTC
I rewrote parts of the patches that were affected by my recent changes to moduleset.py, added the --tags option to list and update commands, and added a little bit of documentation.

2008-01-19  Frederic Peters  <fpeters@0d.be>

        * doc/C/jhbuild.xml, jhbuild/commands/base.py, jhbuild/config.py,
        jhbuild/defaults.jhbuildrc, jhbuild/modtypes/__init__.py,
        jhbuild/moduleset.py, modulesets/moduleset.dtd: implemented a support
        for "tags", modules are automatically tagged with the name of the
        moduleset they are from, and build, update and list commands accept a
        list of tags modules must match to be considered; based on idea and
        patch of Colin Walters.  (closes: #460360)