GNOME Bugzilla – Bug 459100
add contact shouldn't display account on which the Channel_Group_Flag_Can_Add is not set
Last modified: 2008-12-12 09:40:44 UTC
As it doesn't make sense to manually add Salut contacts, Salut accounts shouldn't be displayed in the dialog.
Created attachment 92161 [details] [review] fix This patch fix that problem implementing a new empathy-account-chooser filtering API. Currently Salut is hardcoded but at some point maybe we should add a "add-contact" capability in profile files. This patch also improves the add contact dialog, displaying contact information when user stops to type his ID.
Committed. We still need to refilter accounts when the status change and implement account_chooser_account_remove_foreach().
(In reply to comment #1) > Created an attachment (id=92161) [edit] > fix > > This patch fix that problem implementing a new empathy-account-chooser > filtering API. > Currently Salut is hardcoded but at some point maybe we should add a > "add-contact" capability in profile files. You can look at the group flags to see if it's possible to add people at all.. For salut you can see that Channel_Group_Flag_Can_Add is disabled..
right, didn't thought about that. We need to add an API on EmpathyTpContactList to know if we can add a contact or not.
Note that now group flags should be added to EmpathyTpGroup object.
Same problem with telepathy-sofiasip.
... and telepathy-idle
Proposed fix: http://monkey.collabora.co.uk/empathy.git_add-contact-459100/ http://git.collabora.co.uk/?p=user/cassidy/empathy.git;a=shortlog;h=refs/heads/add-contact-459100 Known bug: if we can't add contacts to any account, the "add button" should be insensitive. Not sure of the right way to do that.
Created attachment 123765 [details] [review] chech the Can_Add flag
I fixed coding style and committed. Thanks for the branch!