GNOME Bugzilla – Bug 457871
Preferred option to show locales for gdmgreeter
Last modified: 2010-06-04 20:19:17 UTC
I think if gdmgreeter could show locales instead of translated/untranslated language names, it's very useful for users. It's a little difficult which locales are used for some languages. I'ld like to add the option to be able to show locales. I'm attaching the patch.
Created attachment 91922 [details] [review] Patch for gui/gdmlanguages.c, gui/gdmlanguages.h Attached the patch. Could you review the attachment?
When you say "gdmgreeter could show locales instead of translated/untranslated language names" I am confused. Do you mean that gdmgreeter/gdmlogin should show locales *in addition* to the translated/untranslated language names? Looking at how the patch works, I assume you mean "in addition to" since it seems the dialog now has 3 columns (untranslated name, translated name, and locale). This looks good to me. I like the ability to see the additional information. As you say, for some users this would be useful. However, it seems I have to click on the right arrow on the top column header to see the locale column and then the left arrow on the top column header to go back to the first view with translated/untranslated name. Why not just make the dialo g a bit wider so all 3 columns can be shown at the same time? This seems better to me.
Yes, I meant the additional name but not the replaced names. Which do you mean to switch 3 names and 2 names with one arrow button or just show 3 names without arrow buttons? The former is to switch: [Current encoding] | [Multi-lingual] | [arrow] and [Current encoding] | [Multi-lingual] | [Locale] | [arrow] The later is to just show: [Current encoding] | [Multi-lingual] | [Locale] I tried to show the dialog likes 3 dimension rotation with the arrow button but actually I could not implement well. My understanding is some people would not want to show the locale names since MS-Windows does not show locales. So I thought the default is 2 names and additional locale name with the arrow button. What do you think?
Created attachment 92182 [details] [review] Patch for gdm.conf.in, gdm-daemon-config-entries.h, gdm-daemon-config-keys.h, gdm.xml, gdmlanguages.c, gdmlogin.c, greeter.c Enhancement Option #2 I updated the patch to use gdm.conf instead of the arrow buttons.
The patch looks really good. Unfortunately this cannot go into 2.19 because we are passed the translation freeze (July 9th) and your change modifies the GDM manual. So I'll accept this patch into 2.21. Do you want this patch to go into the Sun builds for 2.20, though? If so, I can add it to our patches for our Sun builds.
Thanks for the review. Yes, I'ld like to add the patch in vermillion 2.20.
Sorry, I'm going to hold off adding this patch for now, until it is more clear what is going on with the D-Bus enabled branch of GDM. I'm not sure how languages are going to be supported there. Takao, if you wanted to get involved with the new branch and fix any language issues you notice there, that would be handy. Note that the language dialog isn't yet integrated into the simple-greeter, but there is a gdm2/gui/simple-greeter/test-language-chooser test program where you can see how the new language choosing dialog will work. Refer here to get involved with the new branch: http://live.gnome.org/GDM
OK, it seems the current mccann-gobject does not work on Solaris. I just wait until the build issue will be fixed.
Thanks for taking the time to report this bug. However, you are using a version that is too old and not supported anymore. GNOME developers are no longer working on that version, so unfortunately there will not be any bug fixes for the version that you use. By upgrading to a newer version of GNOME you could receive bug fixes and new functionality. You may need to upgrade your Linux distribution to obtain a newer version of GNOME. Please feel free to reopen this bug if the problem still occurs with a newer version of GNOME.