GNOME Bugzilla – Bug 457577
gdm circles and happygnome themes has language menus instead of dialog
Last modified: 2007-07-18 09:23:23 UTC
I'ld like to change all language menus to language dialog boxes in gdmgreeter because I think the scrolling menu items are not useful for users. I also noticed the current circles and happygnome themes have both language menu and language menu item in options menu. One idea is to have a new <menu show="disable"/> tag in the theme .xml files. --- gdm-2.19.3/gui/greeter/themes/circles/circles.xml.orig 2007-07-17 09:35:28.9 88718000 +0900 +++ gdm-2.19.3/gui/greeter/themes/circles/circles.xml 2007-07-17 14:34:20.421286000 +0900 @@ -16,9 +16,12 @@ <item type="button" id="options_button" button="true"> <pos y="5" width="80" height="50"/> <stock type="options"/> + <menu name="lang_menu" show="false"/> + <menu name="session_menu" show="false"/> </item> - <item type="list" id="language" combo="true"> + <item type="button" id="language_button" button="true"> <pos x="25" y="10" height="40" width="300"/> + <stock type="language"/> </item> <item type="list" id="session" combo="true"> <pos x="50" y="10" height="40" width="300"/> I'm attaching the patch.
Created attachment 91880 [details] [review] Patch for greeter_canvas_item.c, greeter_item.[ch], greeter_parser.c, circles.xml, happygnome.xml Attached the patch. Could you review the patch? I don't touch greeter.dtd.
Takao. You say that you want to basically remove the scrolling combo boxes that allow you to change language via selecting them in a combo. You seem to prefer using the dialog. Please explain why you think using the language combo box is not useful. How do you know people don't like to use this feature? If I remove this, will people complain? Also, most distros use their own theme and not the default circles or happygnome themes that ship with GDM. These themes are more to show off the features that GDM supports. Users who want to modify the default themes to remove the combo box can do so.
You're right. distributers modify the default theme. Now I checked the circles and happygnome themes again and it seems the current themes are not wrong. I'll close this as "Not a Bug". Thanks.