After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 453417 - [matroskademux] support palette info for VobSub stream
[matroskademux] support palette info for VobSub stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.6
Other Linux
: Normal enhancement
: 0.10.7
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-07-03 16:04 UTC by Mark Nauwelaerts
Modified: 2007-11-13 17:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implement some VOBSUB CodecPrivate parsing (3.85 KB, patch)
2007-07-03 16:10 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2007-07-03 16:04:45 UTC 
According to specs, CodecPrivate section for a S_VOBSUB stream can provide additional info w.r.t. the stream.  Probably, the most "functionally interesting" are palette data and (possibly) size info.
The former is supported by this patch, the latter info could also be extracted, but should then probably be "pushed along with the caps" and consequently considered by interested elements later on.
Comment 1 Mark Nauwelaerts 2007-07-03 16:10:15 UTC 
Created attachment 91121 [details] [review]
Implement some VOBSUB CodecPrivate parsing

* parses CodecPrivate for palette data and sends this in the proper "dvd-event"
(for dvdsubdec to pick up, for instance)

[note that this is somewhat the demux counterpart of the Matroska subtitle support in bug #415754]
Comment 2 Tim-Philipp Müller 2007-11-13 17:03:51 UTC 
Thanks, committed with minor changes:

 2007-11-13  Tim-Philipp Müller  <tim at centricular dot net>

        Patch by: Mark Nauwelaerts <manauw skynet be>

        * gst/matroska/matroska-demux.c:
          (gst_matroska_demux_push_dvd_clut_change_event),
          (gst_matroska_demux_parse_blockgroup_or_simpleblock),
          (gst_matroska_demux_subtitle_caps):
        * gst/matroska/matroska-ids.h:
          Extract palette data for dvd subpicture streams and send it
          downstream as custom gstreamer dvd event (fixes #453417).

(replaced gst_matroska_demux_make_clut_change_event + loop with an equally questionable but IMHO slightly terser multi-line gst_structure_new(); replaced g_memdup with g_strndup)