GNOME Bugzilla – Bug 453266
support for the windows autorun mecanism - patch included
Last modified: 2007-09-12 00:53:59 UTC
Hello, I have included a patch to implement this specification: https://wiki.ubuntu.com/autorun It would allow to autorun windows cd's by reading the autorun.inf file. First reported on Ubuntu launchpad here: https://bugs.launchpad.net/ubuntu/+source/gnome-volume-manager/+bug/123313
Created attachment 91068 [details] [review] gnome-volume-manager-autorun-inf-01.patch
Created attachment 91114 [details] [review] gnome-volume-manager-autorun-inf-02.patch
implemented this in svn in a much simpler way (e.g. we don't need a full-blown inf parser)
There is a bug with your method when there is a Autorun directory (common with some windows cds) With the old method you don't check if the file is a directory. I will send a patch for the svn version here.
Created attachment 95370 [details] [review] autorun_check_if_dir.patch
aha, thanks, just fixed this in svn
I made some more tests with all my cds and noticed there is still 2 problems. Problem 1: It doesn't work if there are spaces and/or tabs in the open string. Example: OPEN = STARTUP.EXE Problem 2: It doesn't work if there are arguments in the open string. Example: open=start.exe /auto It will fail with this error: ** (gnome-volume-manager:22275): WARNING **: manager.c/1280: failed to exec /media/cdrom0/start.exe /auto: Failed to execute child process "/media/cdrom0/start.exe /auto" (No such file or directory) I can make a patch if you want
ok, just fixed those 2 issues in svn thanks for the testing, my test cases are limited :)