After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 452226 - crossfade everything: pause, next/previous track, etc.
crossfade everything: pause, next/previous track, etc.
Status: RESOLVED OBSOLETE
Product: rhythmbox
Classification: Other
Component: playback
0.11.x
Other All
: Normal minor
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
: 496856 521397 612836 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-06-29 12:29 UTC by y y
Modified: 2018-05-24 12:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fade out when pausing (18.66 KB, patch)
2007-11-08 12:32 UTC, Jonathan Matthew 		none Details | Review
slightly better (18.79 KB, patch)
2007-11-09 01:04 UTC, Jonathan Matthew 		committed Details | Review

Description y y 2007-06-29 12:29:26 UTC 
Please describe the problem:
I think it would be nice to have an option or by default, for Rhythmbnox to crossfade everything concerning playback, incl. Pause, going to the Next/previous track, etc.  Winamp does this and it sounds very smooth.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jonathan Matthew 2007-06-29 23:03:47 UTC 
Track changes are already crossfaded.
Comment 2 Lionel Dricot 2007-08-22 21:14:48 UTC 
I agree that crossfading pause/stop would be nice too.
Comment 3 Jonathan Matthew 2007-11-08 12:32:41 UTC 
Created attachment 98763 [details] [review]
fade out when pausing

Fade out for half a second (not configurable) when pausing, fade in for half a second when unpausing.  Rather than pausing the sink when no streams are playing, set it to NULL.

Also fixes bugs 434142 and 465482 (no decoded data from the paused stream exists in the sink, so it doesn't get played when unpausing it), 484883 (setting gconfaudiosink to NULL should cause it to reread the gconf keys when going to READY), half of 427244 (sink is NULL while paused -> device is closed).
Comment 4 Jonathan Matthew 2007-11-09 01:04:27 UTC 
Created attachment 98795 [details] [review]
slightly better

This should actually fix bug 484883; previously it didn't stop the sink when paused.  Also includes the patch from bug 480764 because I'm lazy.
Comment 5 Jonathan Matthew 2007-11-14 22:24:16 UTC 
*** Bug 496856 has been marked as a duplicate of this bug. ***
Comment 6 James "Doc" Livingston 2007-11-15 12:20:02 UTC 
The patch looks good to me and seems to work pretty well.
Comment 7 Jonathan Matthew 2007-11-25 04:45:49 UTC 
Committed to svn.  There's still more to do here: fading out when completely stopping playback, and particularly when quitting.
Comment 8 Jonathan Matthew 2008-03-09 21:31:41 UTC 
*** Bug 521397 has been marked as a duplicate of this bug. ***
Comment 9 Jonathan Matthew 2010-03-14 00:12:06 UTC 
*** Bug 612836 has been marked as a duplicate of this bug. ***
Comment 10 GNOME Infrastructure Team 2018-05-24 12:39:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/rhythmbox/issues/392.