After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 451912 - Make seek bars share GtkAdjustment
Make seek bars share GtkAdjustment
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
2.19.x
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2007-06-28 15:09 UTC by Bastien Nocera
Modified: 2007-06-29 09:40 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove the fs_seekadj (2.78 KB, patch)
2007-06-28 22:44 UTC, Jan Arne Petersen
none Details | Review

Description Bastien Nocera 2007-06-28 15:09:03 UTC
Quite a few hacks could be removed if both seek bars used the same GtkAdjustment.
Comment 1 Jan Arne Petersen 2007-06-28 22:44:05 UTC
Created attachment 90841 [details] [review]
Remove the fs_seekadj
Comment 2 Sunil Mohan Adapa 2007-06-29 07:10:35 UTC
I did a patch to split the fullscreen code from totem.c as a part of bug #354181. This patch conflicts with that and I have merged this patch into that one.
Comment 3 Bastien Nocera 2007-06-29 09:40:04 UTC
2007-06-29  Bastien Nocera  <hadess@hadess.net>

        * POTFILES.in: upd

2007-06-29  Bastien Nocera  <hadess@hadess.net>

        * data/Makefile.am:
        * data/fullscreen.glade:
        * data/totem.glade:
        * src/Makefile.am:
        * src/totem-fullscreen.*:
        * src/totem-private.h:
        * src/totem.c: (totem_action_exit), (window_state_event_cb),
        (update_mrl_label), (totem_action_set_mrl_with_warning),
        (update_seekable), (update_current_time), (update_volume_sliders),
        (seek_slider_pressed_cb), (seek_slider_changed_cb),
        (seek_slider_released_cb), (totem_action_remote),
        (on_mouse_click_fullscreen), (totem_action_handle_scroll),
        (totem_callback_connect), (video_widget_create), (main):
        Patch from Sunil Mohan Adapa <sunilmohan@gnu.org.in> to split
        the fullscreen popup code into a separate widget (Helps: #354181),
        Patch from Jan Arne Petersen <jpetersen@jpetersen.org> to share
        adjustments between fullscreen and windowed seekbars (Closes: #451912)