After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450777 - PATCH: Use theme-friendly app icons everywhere
PATCH: Use theme-friendly app icons everywhere
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Other Preferences
2.19.x
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-25 01:00 UTC by Michael Terry
Modified: 2007-06-26 23:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (9.03 KB, patch)
2007-06-25 01:01 UTC, Michael Terry 		committed Details | Review

Description Michael Terry 2007-06-25 01:00:43 UTC 
Part of the AppIcon GnomeGoal (http://live.gnome.org/GnomeGoals/AppIcon).

Looking at gnome-control-center's use of application icons, most of its programs already installed icons in the right place and loaded them appropriately.

The only active program I could see that didn't was the display capplet.  I also went ahead and converted the file-type and localization capplets.  I left alone the rollback, url-properties, and mime-type capplets even though they could use a bit of work in this regard since they seemed unused anyway(?).

As part of this, I drastically simplified capplet_set_icon(), since all calls to it now only want icon theme icons and its backup methods won't work for a non-suffixed lookup string anyway.
Comment 1 Michael Terry 2007-06-25 01:01:59 UTC 
Created attachment 90595 [details] [review]
Proposed patch
Comment 2 Jens Granseuer 2007-06-25 17:00:35 UTC 
Looks good, thanks. file-type and localization are obsolete as well, but I guess it can't hurt...

Can you commit?
Comment 3 Michael Terry 2007-06-25 17:15:36 UTC 
I would commit, but I just realized this patch and (I think) parts of the rest of gnome-control-center are missing something.  The update-icon-cache part of the Makefile.am should be triggered on uninstall as well as install.

I'll submit a new patch.  (Or assuming that's all I do, could I just commit directly?)
Comment 4 Jens Granseuer 2007-06-25 17:53:28 UTC 
Sure, go ahead. Thanks again.
Comment 5 Michael Terry 2007-06-26 23:31:06 UTC 
Fixed as I mentioned and committed as revision 7784.