After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450598 - Need to update faad2 include file name and function names in source code
Need to update faad2 include file name and function names in source code
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2007-06-24 12:50 UTC by Joseph Sacco
Modified: 2010-03-15 19:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20



Description Joseph Sacco 2007-06-24 12:50:48 UTC
gst-plugin-bad fails to build because changes in faad2 API are being enforced on some distros. As a result, certain functions have gone missing. Specifically:

/* MACROS FOR BACKWARDS COMPATIBILITY */
/* structs */
#define faacDecHandle                  NeAACDecHandle
#define faacDecConfiguration           NeAACDecConfiguration
#define faacDecConfigurationPtr        NeAACDecConfigurationPtr
#define faacDecFrameInfo               NeAACDecFrameInfo
/* functions */
#define faacDecGetErrorMessage         NeAACDecGetErrorMessage
 #define faacDecSetConfiguration        NeAACDecSetConfiguration
#define faacDecGetCurrentConfiguration NeAACDecGetCurrentConfiguration
#define faacDecInit                    NeAACDecInit
#define faacDecInit2                   NeAACDecInit2
#define faacDecInitDRM                 NeAACDecInitDRM
#define faacDecPostSeekReset           NeAACDecPostSeekReset
#define faacDecOpen                    NeAACDecOpen
#define faacDecClose                   NeAACDecClose
#define faacDecDecode                  NeAACDecDecode
#define AudioSpecificConfig            NeAACDecAudioSpecificConfig


For faad2-2.5-2 [faac-1.25-2] on a Fedora system, the header file faad.h contains only a warning and another include file:

   /* warn people for update */
   #pragma message("please update faad2 include filename and function names!")

   /* Backwards compatible link */
   #include "neaacdec.h"

The current FC7 version of neaacdec.h does *not* contain the macros listed above.  

Adding these definitions allows gst-plugins-bad to build.



-Joseph
Comment 1 Wim Taymans 2010-01-27 11:35:48 UTC
this is a very old bug, is this still valid?
Comment 2 Tobias Mueller 2010-03-15 19:24:07 UTC
Let's assume this is OBSOLETE by now. If it's not, please either reopen or maybe better: file a new bug. TIA!