After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 450444 - Gnumeric needs tango icons
Gnumeric needs tango icons
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: GUI
1.7.x
Other All
: Normal minor
: ---
Assigned To: Jody Goldberg
Jody Goldberg
: 463120 475406 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2007-06-23 19:32 UTC by Vinicius Depizzol
Modified: 2008-08-28 20:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed main icon (18.56 KB, application/x-gzip)
2007-06-23 19:33 UTC, Vinicius Depizzol
  Details
Patch to add icons (36.14 KB, patch)
2007-12-27 02:31 UTC, Seán de Búrca
committed Details | Review
Directory structure for icons (8.68 KB, application/x-bzip)
2007-12-27 02:34 UTC, Seán de Búrca
  Details
Directory structure for icons (9.14 KB, application/x-bzip)
2007-12-31 08:19 UTC, Seán de Búrca
  Details

Description Vinicius Depizzol 2007-06-23 19:32:52 UTC
Since all GNOME desktop is going to following the Freedesktop.org standards, Gnumeric needs new icons.

The main and the application-specific icons should follow http://live.gnome.org/GnomeGoals/AppIcon and http://live.gnome.org/ThemableAppSpecificIcons.

Other information:
Comment 1 Vinicius Depizzol 2007-06-23 19:33:29 UTC
Created attachment 90531 [details]
Proposed main icon
Comment 2 Jody Goldberg 2007-07-06 11:04:55 UTC
Seems reasonable.  I've put it on the list of 'stuff to do' before 1.8
Comment 3 Jody Goldberg 2007-07-27 00:25:17 UTC
I've used these for the win32 icon pack.  Hopefully we can get the icons in for 1.7.12.
Comment 4 Seán de Búrca 2007-12-27 02:31:22 UTC
Created attachment 101655 [details] [review]
Patch to add icons

This patch adds the necessary autotools bits to install the icons and also changes the .desktop and the GtkWindow to use them. I'm not aware of any other uses of the icons but let me know if I've missed something.
Comment 5 Seán de Búrca 2007-12-27 02:34:25 UTC
Created attachment 101656 [details]
Directory structure for icons

A note: it would be great if Vinicius (or someone else with graphical skill) could create a 24x24 icon. I know the 22x22 is there but some things still use 24x24 and it will try to scale up the 22x22 if it isn't there. I've included a 24x24 icon of that size that I created simply by scaling up the 22x22 SVG but it could use some improvement.
Comment 6 Vinicius Depizzol 2007-12-27 10:34:11 UTC
In the Tango Desktop Project Icon Theme guidelines[1] there is an information regarding 22x22 and 24x24 sizes:

> Historically Gnome uses 24×24 size (which is ¼ of 48×48); just adding a 1 pixel empty space on all sides [of 22x22 icon] can make Tango icons useful on the Gnome desktop in the transition phase. One can easily do this with imagemagick:

> convert -bordercolor Transparent -border 1x1 tango_size.png gnome_size.png

Thank you.
Comment 7 Seán de Búrca 2007-12-31 08:19:22 UTC
Created attachment 101886 [details]
Directory structure for icons

Here's an updated tarball for the directory structure containing the properly-created 24x24 icon. Everything should now be ready to commit.
Comment 8 Jody Goldberg 2008-03-04 12:22:00 UTC
*** Bug 475406 has been marked as a duplicate of this bug. ***
Comment 9 Pedro Lino 2008-04-06 00:49:36 UTC
I just found out that under Windows, Gnumeric is still using the file gnumeric-gnome.png (located in share\pixmaps\gnumeric) to display as the task icon instead of win32-gnumeric.ico

This is why the icon showing on the application window and the task bar is still the old icon instead of the new one by Vinicius.

Worst, it is interpolating the 48x48 image to create the 16x16 icon shown (or 32x32 under Emerge Desktop). That is why it always looked worse than the icon embedded in the application (showing in the Windows shortcuts).
Comment 10 Jody Goldberg 2008-05-25 10:41:58 UTC
Patch has been applied to trunk, and will be in 1.9.1
Comment 11 Jody Goldberg 2008-08-28 20:08:50 UTC
*** Bug 463120 has been marked as a duplicate of this bug. ***